[Bug swing/29418] JTree layout broken

[cvs-commit at developer dot classpath dot org]

------- Comment #1 from cvs-commit at developer dot classpath dot org  
2006-10-12 10:38 -------
Subject: Bug 29418

CVSROOT:        /cvsroot/classpath
Module name:    classpath
Changes by:     Roman Kennke <rabbit78> 06/10/12 10:38:28

Modified files:
        .              : ChangeLog 
        javax/swing/tree: AbstractLayoutCache.java 
                          VariableHeightLayoutCache.java 

Log message:
        2006-10-12  Roman Kennke  <address@hidden>

                PR 29418
                * javax/swing/tree/AbstractLayoutCache.java
                (getNodeDimensions): Don't throw InternalError, but instead
                return null.
                (getRowsForPaths): Check for null here.
                (isFixedRowHeight): Returns true when rowHeight > 0.
                (setSelectionModel): Set this as the row mapper for the
selection
                model.
                * javax/swing/tree/VariableHeightLayoutCache.java
                (NodeRecord.NodeRecord): Initialize bounds field.
                (getBounds): Simply return the bounds field.
                (row2Node): Changed to be an ArrayList.
                (RECT_CACHE): New field. Caches a Rectangle instance.
                (countRows): Added y parameter and return value. The method
                now takes the current y position as parameter, and returns
                the updated y position.
                (getBounds): Fixed to return the correct bounds.
                (getPathForRow): Replaced by fixed implementation.
                (getPreferredHeight): Replaced by more efficient
implementation.
                This simply fetches the last node record and returns its lower
                bounds.
                (getPreferredWidth): Added null check.
                (getVisibleChildCount): Added null check.
                (getVisiblePathsFrom): Added null check.
                (setExpandedState): Also expand the ancestors of the node
                to be expanded.
                (setModel): Set dirty flag rather than updating for real.
                (setNodeDimensions): Overridden to set the dirty flag.
                (setRowHeight): Overridden to set the dirty flag.
                (update): Don't special case the root here, this is done now
                in countRows().

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/classpath/ChangeLog?cvsroot=classpath&r1=1.8667&r2=1.8668
http://cvs.savannah.gnu.org/viewcvs/classpath/javax/swing/tree/AbstractLayoutCache.java?cvsroot=classpath&r1=1.12&r2=1.13
http://cvs.savannah.gnu.org/viewcvs/classpath/javax/swing/tree/VariableHeightLayoutCache.java?cvsroot=classpath&r1=1.18&r2=1.19


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=29418