[Bug swing/29644] jircii text overlaps on itself

[cvs-commit at developer dot classpath dot org]

------- Comment #4 from cvs-commit at developer dot classpath dot org  
2006-11-02 11:20 -------
Subject: Bug 29644

CVSROOT:        /cvsroot/classpath
Module name:    classpath
Changes by:     Roman Kennke <rabbit78> 06/11/02 11:20:22

Modified files:
        javax/swing/text: FlowView.java GlyphView.java Utilities.java 
        .              : ChangeLog 

Log message:
        2006-11-02  Roman Kennke  <address@hidden>

                PR 29644
                * javax/swing/text/FlowView.java
                (FlowStrategy.changedUpdate): Reversed condition. This caused
                wrong layout and bad performance.
                (FlowStrategy.insertUpdate): Reversed condition. This caused
                wrong layout and bad performance.
                (FlowStrategy.removeUpdate): Reversed condition. This caused
                wrong layout and bad performance.
                (LogicalView): Changed to be a subclass of CompositeView.
                (LogicalView()): Only take one Element argument.
                (LogicalView.childAllocation): New method for implementing
                the abstract CompositeView method.
                (LogicalView.forwardUpdateToView): Overridden for correct
                reparenting.
                (getMinimumSpan): Overridden to handle line breaking correctly.
                (getPreferredSpan): Implemented to handle line breaking
correctly.
                (getViewAtPoint): New method for implementing
                the abstract CompositeView method.
                (getViewIndexAtPosition): Overridden to handle leaf elements
                correctly.
                (isAfter): New method for implementing
                the abstract CompositeView method.
                (isBefore): New method for implementing
                the abstract CompositeView method.
                (loadChildren): Overridden to handle leaf elements
                correctly.
                (paint): New method for implementing
                the abstract CompositeView method.
                (calculateMinorAxisRequirements): Use preferredSpan in
calculation.
                (loadChildren): Initialize flow layout by sending a synthetic
                insertUpdate() to the layout strategy.
                * javax/swing/text/GlyphView.java
                (DefaultGlyphPainter.getBoundedPosition): Fall back to
Toolkit's
                font metrics if component is not available. Add initial offset
                to result.
                (breakView): Be more clever when breaking the view.
                (getBreakLocation): New helper method to determine a good
                break location.
                (getBreakWeight): Be more clever when breaking the view.
                (getTabbedSpan): Make sure we have a painter. Use view's
                start and end offset rather than the element's.
                * javax/swing/text/Utilities.java
                (drawTabbedText): Avoid useless add and sub with the y offset.

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/classpath/javax/swing/text/FlowView.java?cvsroot=classpath&r1=1.17&r2=1.18
http://cvs.savannah.gnu.org/viewcvs/classpath/javax/swing/text/GlyphView.java?cvsroot=classpath&r1=1.22&r2=1.23
http://cvs.savannah.gnu.org/viewcvs/classpath/javax/swing/text/Utilities.java?cvsroot=classpath&r1=1.38&r2=1.39
http://cvs.savannah.gnu.org/viewcvs/classpath/ChangeLog?cvsroot=classpath&r1=1.8745&r2=1.8746


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=29644