[Bug swing/30337] NPE with own JComboBox if editor nis null

[cvs-commit at developer dot classpath dot org]

------- Comment #5 from cvs-commit at developer dot classpath dot org  
2007-01-06 15:43 -------
Subject: Bug 30337

CVSROOT:        /cvsroot/classpath
Module name:    classpath
Changes by:     Roman Kennke <rabbit78> 07/01/06 15:43:22

Modified files:
        javax/swing/plaf/basic: BasicComboBoxUI.java 
                                BasicComboPopup.java 
        javax/swing/plaf/metal: MetalComboBoxUI.java 
        .              : ChangeLog 

Log message:
        2007-01-06  Roman Kennke  <address@hidden>

                PR 30337
                * javax/swing/plaf/basic/BasicComboBoxUI.java
                (installUI): Install popup and list here.
                Don't configure the arrow button and editor here.
                (installComponents): Don't install popup and list here. (Moved
                to installUI). Configure arrow button here and check for null.
                (addEditor): Configure editor here.
                (configureArrowButton): Directly fetch listeners from popup.
                (paintCurrentValue): Removed unused local variables.
                (layoutContainer): Removed unused local variables.
                (PropertyChangeHandler.propertyChange): Don't invalidate
minimumSize
                on each property change. Avoid calling getPropertyName()
repeatedly.
                Clean up. Call addEditor() when editor changes. Configure and
                unconfigure editor when editable changes. Use 'model' instead
                of non-existing 'dataModel' property.
                * javax/swing/plaf/basic/BasicComboPopup.java
                (uninstallingUI): Remove property change listener and item
listener
                here. Uninstall list listeners. Set model to null to prevent
leakage.
                (configureList): Don't sync list selection there.
                (uninstallComboBoxListeners): Moved to uninstallingUI.
                (uninstallListeners): Moved to uninstallingUI.
                * javax/swing/plaf/metal/MetalComboBoxUI.java
                (createPopup): Call super.
                (getMinimumSize): Removed unused statement.

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/classpath/javax/swing/plaf/basic/BasicComboBoxUI.java?cvsroot=classpath&r1=1.40&r2=1.41
http://cvs.savannah.gnu.org/viewcvs/classpath/javax/swing/plaf/basic/BasicComboPopup.java?cvsroot=classpath&r1=1.19&r2=1.20
http://cvs.savannah.gnu.org/viewcvs/classpath/javax/swing/plaf/metal/MetalComboBoxUI.java?cvsroot=classpath&r1=1.12&r2=1.13
http://cvs.savannah.gnu.org/viewcvs/classpath/ChangeLog?cvsroot=classpath&r1=1.9043&r2=1.9044


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30337