bug-coreutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [coreutils]/lib/getgroups.c, xmalloc usage...


From: Jim Meyering
Subject: Re: [coreutils]/lib/getgroups.c, xmalloc usage...
Date: Wed, 03 Dec 2003 11:29:48 +0100

"Alfred M. Szmidt" <address@hidden> wrote:
> While having a hard time to sleep, I started to read obscure bits of
> code in coreutils.  And found this funny compiler error in
> [kernel]/lib/getgroups.c at line 51:
>
>       /* No need to worry about address arithmetic overflow here,
>        since the ancient systems that we're running on have low
>        limits on the number of secondary groups.  */
>       gbuf = xmalloc (gbuf, n * sizeof *gbuf);
>
> I suppose that nobody has ever used that code, since compiling would
> catch the fact that xmalloc only takes one argument! :-)

Thank you.
I've applied Paul's patch for the coreutils, too.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]