bug-coreutils
[Top][All Lists]
Advanced
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: dd PATCH: add conv=direct

From: Paul Jarc
Subject: Re: dd PATCH: add conv=direct
Date: Thu, 08 Apr 2004 15:51:11 -0400
User-agent: Gnus/5.110002 (No Gnus v0.2) Emacs/21.3 (gnu/linux) 
Paul Eggert <address@hidden> wrote:
> Jim Meyering <address@hidden> writes:
>> 2004-04-08  Jim Meyering  <address@hidden>
>>
>>      * src/dd.c (set_fd_flags): Don't OR in -1 when fcntl fails.
>
> Doesn't that fix generate worse code in the usual case, since it
> causes two conditional branches instead of one?

I think it's unnecessary anyway - if old_flags is -1, then the
conditional jumps to error() before looking at new_flags at all.


paul
reply via email to
[Prev in Thread] Current Thread [Next in Thread]