Re: coreutils CVS test failure on HP-UX 11i

[Jim Meyering]

I wrote:
> Thanks for reporting that.
> I added that test just recently to exercise a bug I found and fixed in rm.
>
>     2004-05-21  Jim Meyering  <address@hidden>
>
>             * tests/rm/inaccessible: New test for the above fix.
>             * tests/rm/Makefile.am (TESTS): Add inaccessible.
>
> I hadn't finished reviewing it, then was away for a week.
> I'll check in the fix pretty soon.

FYI, I've just checked in a fix.
The savannah CVS repository should be sync'd within the hour.

2004-05-22  Jim Meyering  <address@hidden>

        rm -r would get a failed assertion when run from an inaccessible
        directory and with two or more command line arguments including an
        absolute-named directory followed by a relative-named directory.

        * src/remove.h (struct rm_options) [require_restore_cwd]: New member.
        * src/remove.c (struct cwd_state): Define.
        (AD_pop_and_chdir): Redesign interface so that a restore_cwd failure
        can be detected by the caller.  Instead of returning a malloc'd
        directory name, communicate it to caller via a new parameter, and
        return an indication of whether restore_cwd failed.  Update caller.
        Eliminate an unnecessary call to AC_stack_top.
        (remove_dir): Change type of cwd_state parameter to `struct cwd_state'
        so we can now communicate to caller whether/how functions like
        restore_cwd have failed.  Update caller.
        (rm_1): Fail if we've failed to restore the working directory
        and the name of the next file to remove is `.'-relative.
        (rm): Fail if the require_restore_cwd flag is true and we've
        failed to restore the working directory.
        * src/mv.c (rm_option_init): Initialize new member,
        x->require_restore_cwd.
        * src/rm.c (rm_option_init): Likewise.