[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
coreutils src/Makefile.am fixes for Solaris 8 'make' problems
From: |
Paul Eggert |
Subject: |
coreutils src/Makefile.am fixes for Solaris 8 'make' problems |
Date: |
Wed, 28 Jul 2004 11:56:55 -0700 |
User-agent: |
Gnus/5.1006 (Gnus v5.10.6) Emacs/21.3 (gnu/linux) |
"make check" failed on Solaris 8 sparc because Solaris 8 'make'
wouldn't build the groups file: it saw the line "groups: Makefile" and
decided that was enough. I also noticed a lot of needless rebuilding
of localedir.h, which I think I've seen on other platforms too: that
makefile rule is well-intentioned but ineffective since $(localedir)
might be set outside Makefile -- in general, if Makefile changes you
gotta rebuild everything from scratch anyway. I installed this patch.
2004-07-28 Paul Eggert <address@hidden>
* src/Makefile.am ($(SCRIPTS)): Don't depend on Makefile;
this causes Solaris 8 'make' to refuse to build "groups".
(localedir.h): Don't depend on Makefile: this causes Solaris
8 'make' to build localedir.h unnecessarily. The dependence
on Makefile is ineffective anyway, since $(localedir) might
change even if Makefile hasn't.
Index: Makefile.am
===================================================================
RCS file: /home/eggert/coreutils/cu/src/Makefile.am,v
retrieving revision 1.40
retrieving revision 1.41
diff -p -u -r1.40 -r1.41
--- Makefile.am 28 Jul 2004 05:00:35 -0000 1.40
+++ Makefile.am 28 Jul 2004 18:53:22 -0000 1.41
@@ -78,8 +78,6 @@ su_LDADD = $(LDADD) $(LIB_CRYPT)
$(PROGRAMS): ../lib/libfetish.a
-$(SCRIPTS): Makefile
-
SUFFIXES = .sh
.sh:
@@ -163,11 +161,8 @@ editpl = sed -e 's,@''PERL''@,$(PERL),g'
localedir = $(datadir)/locale
BUILT_SOURCES = localedir.h
DISTCLEANFILES = localedir.h
-localedir.h: Makefile
- @rm -f address@hidden
- echo '#define LOCALEDIR "$(localedir)"' >address@hidden
- @chmod a-w address@hidden
- cmp address@hidden $@ > /dev/null 2>&1 && rm -f address@hidden || { rm
-f $@; mv address@hidden $@; }
+localedir.h:
+ echo '#define LOCALEDIR "$(localedir)"' >$@
BUILT_SOURCES += dircolors.h
dircolors.h: dcgen dircolors.hin
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- coreutils src/Makefile.am fixes for Solaris 8 'make' problems,
Paul Eggert <=