Re: I: coreutils-20041123: src/touch.c regression

[Paul Eggert]

Jim Meyering <address@hidden> writes:

> The only other question is whether EROFS is always defined.  This code
> now contains the first use of that symbol in coreutils.  I checked a few
> packages and found that the uses in binutils and cvs are both protected
> with #if directives.  But rsync and openssh use it unconditionally,
> so it's probably ok, these days.

Yes, I think so.  EROFS was in Unix Version 7, so the only problem
would be with (non-POSIX) systems that omitted it for some reason,
which I think is unlikely for realistic coreutils targets.

Binutils is a bit special, since it wants to (or, at least, wanted to)
be portable to the old Mac MPW, which lacks all sorts of errno values
that coreutils assumes (EACCES and ENOENT, for example).  I wouldn't
worry about it much as a precedent here.

CVS 1.12.11 uses EROFS unconditionally; perhaps you were looking at an
older version of CVS?

Other than binutils, the uses of "#ifdef EROFS" that I've seen seem to
stem from paranoia rather than real need.