Re: more 5.3.0 issues on cygwin

[Eric Blake]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

According to Jim Meyering on 1/17/2005 4:09 PM:
> Eric Blake <address@hidden> wrote:
> ...
> 
>>        * src/od.c (OPENMODE): New macro.
>>        (open_next_file): Use OPENMODE in fopen call.
> 
> ...
> 
> 
> Why is that needed?
> od.c already does this:
> 
>   SET_BINARY (fileno (in_stream));
> 
> # define SET_BINARY(_f) do {if (!isatty(_f)) setmode (_f, O_BINARY);} while 
> (0)
> 
> Maybe those #if directives don't work on your system?
> 

I withdraw the install.c and od.c changes.  You are correct that the
install.c changes are too specific to cygwin; and Corinna, on the cygwin
mailing list, confirmed that there is indeed a bug in setmode in the
current cygwin 1.5.12 release (it only works for file descriptors 0, 1,
and 2), but which has been fixed in CVS.  Her OPENMODE patch was inserted
as a workaround in the meantime.

However, the Makefile.am patches are still important to allow the
tests/help-version script to succeed without filling the disk (otherwise,
you eval `args=$yes.exe_args', then run `yes.exe .exe_args' which runs
away, rather than the intended `yes --version').  Likewise, the system.h
patch is necessary for df (NTFS uses 1k blocks as captured in S_BLKSIZE,
but without the patch, ST_NBLOCKSIZE defaults to 512, so sizes were 50% of
their correct value).

2005-01-17  Eric Blake  <address@hidden>  (tiny change)

        * src/Makefile.am (all_programs.list): Strip $(EXEEXT) and remove
        duplicates.
        * man/Makefile.am (all_programs): Revert previous patch; updated
        all_programs.list fixes this.
        (.x.1): No need to add $(EXEEXT).

2005-01-03  Corinna Vinschen  <address@hidden>  (tiny change)

        * src/system.h: Use S_BLKSIZE value for ST_NBLOCKSIZE where
        available.

- --
Life is short - so eat dessert first!

Eric Blake             address@hidden
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.0 (Cygwin)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFB7lpH84KuGfSFAYARAq1mAJkBsPW6mSxwtdAfQjGwXrkYD4PJvwCgzJf6
eDmqqayapkgp8Q0MHB8qkpo=
=SsvO
-----END PGP SIGNATURE-----