[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: perm test and ACLs
From: |
Paul Eggert |
Subject: |
Re: perm test and ACLs |
Date: |
Wed, 22 Jun 2005 11:11:19 -0700 |
User-agent: |
Gnus/5.1006 (Gnus v5.10.6) Emacs/21.4 (gnu/linux) |
"Kevin Mudrick" <address@hidden> writes:
> Similar to the cp-parents problem I reported yesterday,
If this is going to be a recurrent problem, we should package it
up as a separate -check file. I installed this; does it work for you?
2005-06-22 Paul Eggert <address@hidden>
* tests/umask-check: New file.
* tests/Makefile.am (EXTRA_DIST): Add umask-check.
* tests/mkdir/perm: Use umask-check.
* tests/cp/cp-parents: Likewise, instead of using chmod
as described below. Problem reported by Kevin Mudrick.
Index: tests/Makefile.am
===================================================================
RCS file: /fetish/cu/tests/Makefile.am,v
retrieving revision 1.21
diff -p -u -r1.21 Makefile.am
--- tests/Makefile.am 20 Apr 2005 07:53:53 -0000 1.21
+++ tests/Makefile.am 22 Jun 2005 18:03:37 -0000
@@ -16,7 +16,7 @@ TESTS_ENVIRONMENT = \
EXTRA_DIST = \
$(TESTS) .env-warn Coreutils.pm Makefile.am.in README envvar-check \
expensive group-names input-tty lang-default mk-script priv-check \
- rwx-to-mode sample-test setgid-check
+ rwx-to-mode sample-test setgid-check umask-check
SUBDIRS = \
basename chgrp chmod chown cp cut date dd dircolors du expr factor \
Index: tests/mkdir/perm
===================================================================
RCS file: /fetish/cu/tests/mkdir/perm,v
retrieving revision 1.17
diff -p -u -r1.17 perm
--- tests/mkdir/perm 29 Apr 2005 21:49:06 -0000 1.17
+++ tests/mkdir/perm 22 Jun 2005 18:03:37 -0000
@@ -28,6 +28,7 @@ if test $framework_failure = 1; then
fi
. $abs_srcdir/../setgid-check
+. $abs_srcdir/../umask-check
fail=0
Index: tests/cp/cp-parents
===================================================================
RCS file: /fetish/cu/tests/cp/cp-parents,v
retrieving revision 1.14
diff -p -u -r1.14 cp-parents
--- tests/cp/cp-parents 22 Jun 2005 07:38:06 -0000 1.14
+++ tests/cp/cp-parents 22 Jun 2005 18:03:37 -0000
@@ -22,6 +22,7 @@ abs_srcdir=`pwd`
cd $pwd || framework_failure=1
. $srcdir/../envvar-check
+. $srcdir/../umask-check
mkdir -p $tmp || framework_failure=1
cd $tmp || framework_failure=1
@@ -31,9 +32,6 @@ cd $tmp || framework_failure=1
mkdir foo bar || framework_failure=1
mkdir -p a/b/c d e || framework_failure=1
-# Systems with ACLs might need this, if ACLs override umask.
-chmod -R 755 a d e || framework_failure=1
-
if test $framework_failure = 1; then
echo 'failure in testing framework'
exit 1