bug-coreutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: ln.c portability fix for hosts where / != //


From: Jim Meyering
Subject: Re: ln.c portability fix for hosts where / != //
Date: Sat, 05 Nov 2005 10:45:41 +0100

Paul Eggert <address@hidden> wrote:
> Jim Meyering <address@hidden> writes:
>
>> But if someone submits a clean patch, I'll consider it.
>
> Here's a patch that I hope is clean enough; it shortens the source
> code by 18 lines.  It doesn't fix any bugs so I have not installed it.
>
> 2005-11-04  Paul Eggert  <address@hidden>
>
>       * src/ln.c: Include filenamecat.c.
>       (FILE_BASENAME_CONCAT): Remove.
>       (do_link): Remove last arg DEST_IS_DIR.  All callers changed.
>       (main): Use file_name_concat, base_name, and strip_trailing_slashes
>       instead of FILE_BASENAME_CONCAT.  This simplifies the code, and avoids
>       the use of alloca.

That looks fine.
I've checked it in to the trunk.
Thanks!




reply via email to

[Prev in Thread] Current Thread [Next in Thread]