Re: coreutils-5.92:du not AIX largefile safe --

[Jim Meyering]

Paul Townsend <address@hidden> wrote:
...
> Part of this mod is a rewrite of the check code.  I think everything in
> it is globally supported.
>
> FWIW, the `seq' executable doesn't exist on the Solaris boxes (at least
> I couldn't find it).  I replaced it with an `expr' invocation.  It could

Using seq here is fine, since it is part of the coreutils package,
and all tests are invoked with $PATH including coreutils/src.

This test should fail if $MULTI_GIGABYTE_TMPDIR isn't an existing
directory.  It must not create that directory.  You can use something
like this from the tac-continue test:

  if ! test -d "$FULL_PARTITION_TMPDIR"; then
    echo "$0: $FULL_PARTITION_TMPDIR:" \
      "\$FULL_PARTITION_TMPDIR does not specify a directory" 1>&2
    (exit 1); exit 1
  fi

With your additions, the diagnostic

  echo "$0: skipping this test:"
  echo "too little free space on current partition: $free_kb (need $min_kb KB)" 
\

is misleading.  If we skip the test, it should mention the new
envvar name so that people know which knob to turn in case they
really do want to run the test.

...
> -  test $i = 100 && { printf %48s x >> $big || fail=1; }
> -  test -t 1 && printf 'creating a 2GB file: %d%% complete\r' $i
> +  test $i -eq 100 && { printf %48s x >> $big || fail=1; }
> +  test -t 1 && printf 'Creating a 2GB file: %d%% complete\r' $i

Why change `=' to `-eq'?
The latter would give a diagnostic if the arguments aren't numeric,
and we need to worry about leading zeroes or a suffix like .0.

Thanks for persevering.