bug-coreutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

tests/acl fixes for Solaris 8


From: Paul Eggert
Subject: tests/acl fixes for Solaris 8
Date: Thu, 15 Dec 2005 11:01:52 -0800
User-agent: Gnus/5.1007 (Gnus v5.10.7) Emacs/21.4 (gnu/linux)

"make check" failed on Solaris 8 because its shell didn't grok the
syntax used in tests/acl.  Also, I noticed it assumed /etc/passwd
exists and contains all the user names, which isn't true for (e.g.,
NIS-based systems).  I installed this:

2005-12-15  Paul Eggert  <address@hidden>

        * tests/acl: Port to pre-POSIX shells like Solaris 8 /bin/sh.
        Don't assume /etc/passwd contains user names; use 'id' instead.

--- tests/acl   24 Nov 2005 17:24:36 -0000      1.2
+++ tests/acl   15 Dec 2005 19:01:00 -0000      1.4
@@ -1,18 +1,17 @@
-if ! getfacl --version 2> /dev/null 1>&2 || \
-   ! setfacl --version 2> /dev/null 1>&2 ; then
+getfacl --version 2> /dev/null 1>&2 && setfacl --version 2> /dev/null 1>&2 || {
   cat <<EOF 1>&2
 **************************************
 $0: This test requires getfacl and setfacl.
 **************************************
 EOF
   (exit 77); exit 77
-fi
+}
 
-if ! grep '^bin:' /etc/passwd 2> /dev/null 1>&2 ; then
+id -u bin 2> /dev/null 1>&2 || {
   cat <<EOF 1>&2
 **************************************
 $0: This test requires a local user named bin.
 **************************************
 EOF
   (exit 77); exit 77
-fi
+}




reply via email to

[Prev in Thread] Current Thread [Next in Thread]