Re: ia64 GNU/Linux pwd-long test failure in CVS coreutils

[Jim Meyering]

address@hidden (Bob Proulx) wrote:
...
> One thing that I am a little worried about by the test is the initial
> mkdir call.
>
>       if (mkdir (dir_name, S_IRWXU) < 0 || chdir (dir_name) < 0)
>         {
>           fail = 3; /* Unable to construct deep hierarchy.  */
>
> That also fails if remnants of the test structure are left behind by a
> previous failed run of the test or if there is not enough permission
> to create a directory and other things like that.  Not sure that is
> really bad but my paranoia causes me to suggest that the first mkdir
> be checked individually to separate out the two different types of
> failures.  And then it always tries to rmdir regardless in that case.
> Check this out.

Right.
In the driver .m4/shell code I'll be careful to make sure things
are cleaned up both before and after.