bug-coreutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

tests -- file redirection ordering


From: Bob Proulx
Subject: tests -- file redirection ordering
Date: Tue, 27 Jun 2006 18:55:57 -0600
User-agent: Mutt/1.5.9i

Seeing the redirection problem of the previous message I looked
through all of the tests looking for other potential problems.  I did
not find any real problems.  But I did see two other cases of the
"odd" file redirections.  This is really trivial but it would be good
to keep the style consistent among all of the tests.  This trivial
change brings these into the common style.

Bob

        * tests/dd/unblock-sync: Order shell file redirections for
        stderr and stdout in the common style.
        tests/mv/i-link-no: Likewise.

Index: dd/unblock-sync
===================================================================
RCS file: /sources/coreutils/coreutils/tests/dd/unblock-sync,v
retrieving revision 1.2
diff -u -r1.2 unblock-sync
--- dd/unblock-sync     2 Nov 2005 20:44:59 -0000       1.2
+++ dd/unblock-sync     28 Jun 2006 00:32:41 -0000
@@ -25,7 +25,7 @@
 
 fail=0
 
-dd cbs=4 ibs=4 conv=unblock,sync < in 2>/dev/null > out || fail=1
+dd cbs=4 ibs=4 conv=unblock,sync < in > out 2> /dev/null || fail=1
 cat <<\EOF > exp || fail=1
 0001
 0002
Index: tests/acl
===================================================================
RCS file: /sources/coreutils/coreutils/tests/acl,v
retrieving revision 1.5
diff -u -r1.5 acl
--- tests/acl   13 Jan 2006 13:38:39 -0000      1.5
+++ tests/acl   28 Jun 2006 00:40:18 -0000
@@ -1,5 +1,5 @@
-getfacl --version < /dev/null 2> /dev/null 1>&2 \
-  && setfacl --version < /dev/null 2> /dev/null 1>&2 || {
+getfacl --version < /dev/null > /dev/null 2>&1 \
+  && setfacl --version < /dev/null > /dev/null 2>&1 || {
   cat <<EOF 1>&2
 **************************************
 $0: This test requires getfacl and setfacl.
@@ -8,7 +8,7 @@
   (exit 77); exit 77
 }
 
-id -u bin 2> /dev/null 1>&2 || {
+id -u bin > /dev/null 2>&1 || {
   cat <<EOF 1>&2
 **************************************
 $0: This test requires a local user named bin.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]