Re: coreutils-6.0: "make" output on MacOS X

[Jim Meyering]

Bruno Haible <address@hidden> wrote:
> The problem is the gzip call in Makefile.maint. "make" is GNU make 3.79.
> "gzip" is 1.2.4, and it prints --help output to stderr.
>
> The appended patch fixes the problem.
>
> Bruno
>
>
> 2006-08-16  Bruno Haible  <address@hidden>
>
>       * Makefile.maint (gzip_rsyncable): Throw away stderr output of
>       "gzip --help".

Thanks for reporting/fixing that.  Applied.

BTW, I find unified diffs to be more readable, especially
for one-liners like that.

> *** Makefile.maint    15 Aug 2006 12:13:04 -0000      1.243
> --- Makefile.maint    16 Aug 2006 12:27:47 -0000
> ***************
> *** 26,32 ****
>   # Do not save the original name or timestamp in the .tar.gz file.
>   # Use --rsyncable if available.
>   gzip_rsyncable := \
> !   $(shell gzip --help|grep rsyncable >/dev/null && echo --rsyncable)
>   GZIP_ENV = '--no-name --best $(gzip_rsyncable)'
>
>   CVS = cvs
> --- 26,32 ----
>   # Do not save the original name or timestamp in the .tar.gz file.
>   # Use --rsyncable if available.
>   gzip_rsyncable := \
> !   $(shell gzip --help 2>/dev/null|grep rsyncable >/dev/null && echo 
> --rsyncable)