Re: coreutils-6.0: numerous test failures on MacOS X

[Paul Eggert]

I installed this patch to coreutils to address the O_DIRECTORY
problem; it assumes the new gnulib fcntl module.

2006-08-28  Paul Eggert  <address@hidden>

        Adjust to recent gnulib changes for the gnulib module.
        * bootstrap.conf (gnulib_modules): Add fcntl.
        * src/system.h (SEEK_SET, SEEK_CUR, SEEK_END): Remove.  Other code
        is already assuming these macros are defined.
        (O_DIRECT, O_DIRECTORY, O_DSYNC, O_NDELAY, O_NOATIME, O_NONBLOCK):
        (O_NOCTTY, O_NOFOLLOW, O_NOLINKS, O_RSYNC, O_SYNC, O_BINARY, O_TEXT):
        Remove; the fcntl module now handles these.

Index: bootstrap.conf
===================================================================
RCS file: /fetish/cu/bootstrap.conf,v
retrieving revision 1.6
diff -p -u -r1.6 bootstrap.conf
--- bootstrap.conf      28 Aug 2006 20:51:56 -0000      1.6
+++ bootstrap.conf      28 Aug 2006 23:02:51 -0000
@@ -41,7 +41,7 @@ gnulib_modules="
        c-strtold calloc canon-host canonicalize chown cloexec
        config-h configmake
        closeout cycle-check d-ino d-type diacrit dirfd dirname dup2
-       error euidaccess exclude exitfail fcntl-safer fdl file-type
+       error euidaccess exclude exitfail fcntl fcntl-safer fdl file-type
        fileblocks filemode filenamecat fnmatch-gnu fopen-safer
        fprintftime fsusage ftruncate fts getdate getgroups gethrxtime
        getline getloadavg getndelim2 getopt getpagesize getpass-gnu
Index: src/system.h
===================================================================
RCS file: /fetish/cu/src/system.h,v
retrieving revision 1.157
diff -p -u -r1.157 system.h
--- src/system.h        28 Aug 2006 20:51:56 -0000      1.157
+++ src/system.h        28 Aug 2006 23:02:52 -0000
@@ -152,11 +152,6 @@ initialize_exit_failure (int status)
 
 #include <fcntl.h>
 
-#if !defined SEEK_SET
-# define SEEK_SET 0
-# define SEEK_CUR 1
-# define SEEK_END 2
-#endif
 #ifndef F_OK
 # define F_OK 0
 # define X_OK 1
@@ -164,74 +159,6 @@ initialize_exit_failure (int status)
 # define R_OK 4
 #endif
 
-#if !defined O_DIRECT && defined O_DIRECTIO
-/* Tru64 spells it `O_DIRECTIO'.  */
-# define O_DIRECT O_DIRECTIO
-#endif
-
-#if !defined O_DIRECT
-# define O_DIRECT 0
-#endif
-
-#if !defined O_DIRECTORY
-# define O_DIRECTORY 0
-#endif
-
-#if !defined O_DSYNC
-# define O_DSYNC 0
-#endif
-
-#if !defined O_NDELAY
-# define O_NDELAY 0
-#endif
-
-#if !defined O_NOATIME
-# define O_NOATIME 0
-#endif
-
-#if !defined O_NONBLOCK
-# define O_NONBLOCK O_NDELAY
-#endif
-
-#if !defined O_NOCTTY
-# define O_NOCTTY 0
-#endif
-
-#if !defined O_NOFOLLOW
-# define O_NOFOLLOW 0
-#endif
-
-#if !defined O_NOLINKS
-# define O_NOLINKS 0
-#endif
-
-#if !defined O_RSYNC
-# define O_RSYNC 0
-#endif
-
-#if !defined O_SYNC
-# define O_SYNC 0
-#endif
-
-/* For systems that distinguish between text and binary I/O.
-   O_BINARY is usually declared in fcntl.h  */
-#if !defined O_BINARY && defined _O_BINARY
-  /* For MSC-compatible compilers.  */
-# define O_BINARY _O_BINARY
-# define O_TEXT _O_TEXT
-#endif
-
-#ifdef __BEOS__
-  /* BeOS 5 has O_BINARY and O_TEXT, but they have no effect.  */
-# undef O_BINARY
-# undef O_TEXT
-#endif
-
-#ifndef O_BINARY
-# define O_BINARY 0
-# define O_TEXT 0
-#endif
-
 #include <dirent.h>
 #ifndef _D_EXACT_NAMLEN
 # define _D_EXACT_NAMLEN(dp) strlen ((dp)->d_name)