Re: coreutils-6.1: needs 'ls' patch (bug #15043)

[Eric Blake]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

According to mwoehlke on 8/28/2006 9:58 AM:
>> I don't see why the behavior of 'ls' should depend on whether the
>> Linux kernel is used.  Shouldn't coreutils 'ls' behave the same way on
>> FreeBSD or Solaris?
> 
> The *old* behavior depends on the kernel. Although I can't vouch for
> FreeBSD, I tested on Solaris (both SPARC 2.6 and x86 10) and several
> other platforms, and in 5.97 / 6.1, Linux was the *only* platform I
> tested on which it did not work. All of which is in the Savannah comments.
> 
> I #ifdef'd the change to avoid doing unnecessary work on platforms that
> work correctly without the extra call.

Look more closely at the code.  The reason linux was failing was because
it was not doing enough work, because the d_type shortcut let it skip a
stat where one was needed.  Platforms that did not have the bug are not
doing extra work, because they have already done the stat (not having a
d_type shortcut to rely on).  So #ifdef'ing on linux is not the right
approach, and Jim's patch was appropriate.

- --
Life is short - so eat dessert first!

Eric Blake             address@hidden
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2.1 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFE9k3684KuGfSFAYARAvT1AJ9PMHits6dC0sTKZ8bPlLpEGGYN2wCgow2X
ogzOnnaQ5k7hx0RMKtGF25k=
=WreX
-----END PGP SIGNATURE-----