Re: coreutils-6.8 does not compile

[Jim Meyering]

Elias Pipping <address@hidden> wrote:
> I must have had a look at the wrong log when I said that... still
> having the same error. sorry.

>>>> FAIL: pwd-unreadable-parent

Thanks for the correction.
I've fixed it with a big hammer: skip the test.

        pwd-unreadable-parent: Skip test on non-Linux/GNU systems.
        * tests/misc/pwd-unreadable-parent: Rather than trying to decide
        whether this test has a chance of succeeding, run it only when
        $(host_os) is linux-gnu.  It was failing on powerpc-apple-darwin8.8.0
        * tests/misc/Makefile.am (TESTS_ENVIRONMENT): Add host_os=$(host_os).

The latest snapshot includes that change:

  http://meyering.net/cu/coreutils-6.8+.tar.gz


diff --git a/tests/misc/Makefile.am b/tests/misc/Makefile.am
index 5ecd451..1aa3516 100644
--- a/tests/misc/Makefile.am
+++ b/tests/misc/Makefile.am
@@ -30,6 +30,7 @@ TESTS_ENVIRONMENT = \
   PATH="$(VG_PATH_PREFIX)`pwd`/../../src$(PATH_SEPARATOR)$$PATH" \
   CONFIG_HEADER=$(CONFIG_HEADER) \
   REPLACE_GETCWD=$(REPLACE_GETCWD) \
+  host_os=$(host_os) \
   PROG=`../../src/basename -- "$$tst"`

 # Do not choose a name that is a shell keyword like 'if', or a
diff --git a/tests/misc/pwd-unreadable-parent b/tests/misc/pwd-unreadable-parent
index ace73f9..801805a 100755
--- a/tests/misc/pwd-unreadable-parent
+++ b/tests/misc/pwd-unreadable-parent
@@ -26,17 +26,9 @@ if test "$VERBOSE" = yes; then
   readlink --version
 fi

-skip=1
-# Run this test IFF:
-# if REPLACE_GETCWD is 0 (system getcwd is good enough)
-#   or HAVE_PARTLY_WORKING_GETCWD is defined
-test $REPLACE_GETCWD = 0 && skip=0
-test $skip = 1 &&
-  grep '^#define HAVE_PARTLY_WORKING_GETCWD ' $CONFIG_HEADER > /dev/null &&
-    skip=0
-test $skip = 1 &&
+test $host_os != linux-gnu &&
   {
-    echo 1>&2 "$0: inadequate system getcwd; skipping this test"
+    echo 1>&2 "$0: vendor getcwd may be inadequate; skipping this test"
     (exit 77); exit 77
   }