Re: [PATCH] add new sort option --xargs (-x)

[Bo Borgerson]

On Sun, Apr 6, 2008 at 4:30 PM, Jim Meyering <address@hidden> wrote:
>  s/texti/texi/
>  Please use capitals and periods in ChangeLogs. ;-)
>  s/null/NUL/
>  Split the string.  Otherwise, your addition pushes its length beyond
>  a portability limit whose exact number I forget but it's around 500.
>  No big deal, but it's good practice to alphabetize.
>  This should have only 1 year number: 2008.

Thanks.  I'll try to catch this sort of thing myself in the future.


>  Now, your doc change will be to add this line:
>
>  @files0fromOption{sort,}

I added an argument to the macro that specifies output for sub-lists,
since it's 'a total' for wc and du, but 'sorted output' for sort.


>  If the file is based on some other, please indicate that.
>  That will help me as reviewer, and future maintainers.
>
>  E.g., I put this comment in the wc test of --files0-from:
>
>   # This file bears a striking resemblance to tests/du/files0-from.

Unfortunately I didn't just copy one of the relevant test files.  If
it would be easier for maintenance to have a more direct copy I can
redo it.  I added a line at the top indicating that this test script
covers a lot of the same ground as the wc-files0-from tests.

Thanks,

Bo

sort-files0-from-3.diff
Description: Text Data