[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Problems with coreutils-6.10.176-383b1.tar.gz
|
From: |
Eric Blake |
|
Subject: |
Re: Problems with coreutils-6.10.176-383b1.tar.gz |
|
Date: |
Mon, 14 Apr 2008 13:03:41 -0600 |
|
User-agent: |
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.12) Gecko/20080213 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 |
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
According to Jim Meyering on 4/14/2008 11:13 AM:
|
| if (xstrtold (x_str + layout.prefix_len, NULL, &x_val, c_strtold)
| - && x_val == last)
| + && abs_rel_diff (x_val, last) < DBL_EPSILON)
Don't you need to scale the result of abs_rel_diff to be on the same order
of magnitude as x_val? DBL_EPSILON represents 1 ulp of 1.0, but 2 ulps of
0.5. It seems like what you are really trying to do here is terminate
when the result is within 1 or 2 ulps, not when the result is less than
DBL_EPSILON off.
- --
Don't work too hard, make some time for fun as well!
Eric Blake address@hidden
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iEYEARECAAYFAkgDqowACgkQ84KuGfSFAYDEHwCaAlLyED0ugXvRten1/YeFE+Qe
wEoAoLPTAisJ7iK06mwipLfsK0my72HK
=vSJK
-----END PGP SIGNATURE-----