[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Use a hash rather than a linked-list for cycle check in cp
From: |
Jim Meyering |
Subject: |
Re: [PATCH] Use a hash rather than a linked-list for cycle check in cp |
Date: |
Tue, 22 Apr 2008 21:58:35 +0200 |
"Bo Borgerson" <address@hidden> wrote:
> On Tue, Apr 22, 2008 at 3:03 PM, Jim Meyering <address@hidden> wrote:
>>
>> Hi Bo,
>>
>> Thanks for that patch.
>>
>> However, let's see if Cai Xianchao and Li Zefan
>> are still working on rewriting cp to use openat-style functions.
>>
>> http://thread.gmane.org/gmane.comp.gnu.coreutils.bugs/12041
>>
>> Because once cp is rewritten the way I outlined later in
>> that thread, there will be no need for your patch.
>
> Hi,
>
> I may be missing something, but from a scan of that thread it seems to
> me that the two patches are actually mutually beneficial.
The change I want is to make cp use fts,
and fts already does efficient cycle detection.