Re: Surprising bug in sort

[Eric Blake]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

According to Jim Meyering on 8/18/2008 10:25 AM:
>>> This question comes up frequently.  Is there some wording we can use to
>>> make it more obvious that omitting POS2 implies end of line, while still
>>> being brief enough for --help output?
>> "...end it at POS2 (or the end of the line, if omitted)"?
> 
> Sounds good.  Want to write the patch?
> 

Attached, or 'git pull git://repo.or.cz/coreutils/ericb.git sort'.

- --
Don't work too hard, make some time for fun as well!

Eric Blake             address@hidden
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkiqRB4ACgkQ84KuGfSFAYBjegCff3qY5lyRtG47xJhdqNg0c2On
cz4An0dbWmSABQRxR4RwyK8a+6IEuIWT
=DvPZ
-----END PGP SIGNATURE-----

>From edd292f8d4a5845bcc0d01ab080a6fc9f51a36fa Mon Sep 17 00:00:00 2001
From: Eric Blake <address@hidden>
Date: Mon, 18 Aug 2008 21:50:27 -0600
Subject: [PATCH] sort: improve usage wording

* src/sort.c (usage): Mention that -k defaults to end of line if
POS2 omitted.
* THANKS: Update.
Reported by Tim Ryan.

Signed-off-by: Eric Blake <address@hidden>
---
 THANKS     |    1 +
 src/sort.c |    3 ++-
 2 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/THANKS b/THANKS
index 021ff6a..ea07d07 100644
--- a/THANKS
+++ b/THANKS
@@ -521,6 +521,7 @@ Thomas Schwinge                     address@hidden
 Thomas Wolff                        address@hidden
 Tim J. Robbins                      address@hidden
 Tim Mooney                          address@hidden
+Tim Ryan                            address@hidden
 Tim Smithers                        address@hidden
 Tim Waugh                           address@hidden
 Toby Peterson                       address@hidden
diff --git a/src/sort.c b/src/sort.c
index a617517..37eb854 100644
--- a/src/sort.c
+++ b/src/sort.c
@@ -362,7 +362,8 @@ Other options:\n\
                             NUL-terminated names in file F\n\
 "), stdout);
       fputs (_("\
-  -k, --key=POS1[,POS2]     start a key at POS1, end it at POS2 (origin 1)\n\
+  -k, --key=POS1[,POS2]     start a key at POS1 (origin 1), end it at POS2\n\
+                            (default end of line)\n\
   -m, --merge               merge already sorted files; do not sort\n\
 "), stdout);
       fputs (_("\
-- 
1.5.6.4