Re: sort --version-sort

[Eric Blake]

Jim Meyering <jim <at> meyering.net> writes:

> > Would you rather I submit a simple patch to coreutils that adds
> > #include "strverscmp.h" to sort.c, or a more complete patch to gnulib that
> > guarantees a declaration of strverscmp in the gnulib replacement <string.h> 
to
> > match Linux?
> 
> What service 
> 
> I think we'll have to include "strverscmp.h",
> since portable applications should be expecting a
> strverscmp declaration in string.h.

Missing a "not" somewhere in there.  But I disagree about what a portable app 
should expect - the point of gnulib replacement headers is that we guarantee 
that <string.h> will portably declare strverscmp.  For comparison, look at how 
we rely on the gnulib headers for other GNU extensions such as strcasestr.  
Besides, fixing it in gnulib will benefit any other package developed primarily 
on Linux but which forgets to include "strverscmp.h".  So I'm going ahead with 
a gnulib patch... oh, and I guess that means I'm also volunteering to write a 
gnulib unit test for strverscmp...

-- 
Eric Blake