bug-coreutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: fix du and wc wrt --files0-from=F


From: Pádraig Brady
Subject: Re: fix du and wc wrt --files0-from=F
Date: Mon, 1 Dec 2008 23:23:10 +0000
User-agent: Thunderbird 2.0.0.6 (X11/20071008)

Jim Meyering wrote:
> 
>>From 622f12ed8fd799ad83546233a60655a6a0d2a4b6 Mon Sep 17 00:00:00 2001
> From: Jim Meyering <address@hidden>
> Date: Tue, 25 Nov 2008 18:38:26 +0100
> Subject: [PATCH 2/2] wc: read and process --files0-from= input a name at a 
> time,
> 
> when the file name list is not too large.  Before, wc would always
> reading the entire file name list into RAM and *then* process each
      ^^^
> file name.
> * src/wc.c: Include "argv-iter.h".
> (main): Rewrite to use argv-iter when the input file name list
> is known to be too large.
> * NEWS (Bug fixes): Mention it.

I'd also mention why wc tries to read the whole list into RAM
if there's place (so that it can auto align the numbers outputted).
I'm not sure number alignment is worth this extra code/complexity,
but it's written now :)

I presume you're not forgetting sort --files0-from as
you've previously mentioned it.

cheers,
Pádraig.






reply via email to

[Prev in Thread] Current Thread [Next in Thread]