Re: misc/groups-dash fails due to enable-no-install-program=groups

[Jim Meyering]

Mike Frysinger wrote:
> On Thursday 12 March 2009 09:05:25 Jim Meyering wrote:
>> Mike Frysinger wrote:
>> > it's been a while, so i dont remember if this has been reported already,
>> > but if groups is disabled via the command line, the misc/groups-dash test
>> > is still run.  since the groups program is not coming from coreutils, the
>> > output is not as expected and things fail.  perhaps a new func in
>> > test-lib.sh like: require_program_()
>> > {
>> >   test -x "$abs_top_builddir/src/$1" || \
>> >     skip_test_ "the $1 program was disabled"
>> > }
>> > and then the groups test can do:
>> > require_program_ groups
>>
>> There's already a require_built_ function, but it's not really well-named,
>> since the programs you'd name as argument *are* built.  The configure-time
>> --enable-no-install-program option determines solely whether to install
>> them.  For example, even though most builds don't install "arch", you'll
>> notice that it *is* always built.  This is a feature: it helps prevent
>> bit rot of programs that few will end up actually using.  At least we'll
>> know they still compile.
>
> are you sure about that ?  i downloaded the snapshot you just posted and ran:
>
>>   ./configure --enable-no-install-program=groups && make
>
> and i did not get a src/groups binary

Humph.  You're right.
So my test was wrong, not to mention my memory of how
--enable-no-install-program works.  Sheesh.

Let's see where that test went wrong.

Oh!  That test passes even when groups fails (exits with status 2)
and generates no output.

Sure, it detected the bug it was intended to, but not much else.
I'll fix that along with the problem you spotted.