Re: Recent git commit breaks build on Solaris

[David Bartley]

On Sat, Mar 14, 2009 at 11:06 AM, Jim Meyering <address@hidden> wrote:
> David Bartley wrote:
>> Just a quick heads up, the following commit breaks the build on Solaris:
>>
>> http://git.savannah.gnu.org/gitweb/?p=coreutils.git;a=commitdiff;h=55efc5f3ee485b3e31a91c331f07c89aeccc4e89
>>
>> In src/system.h, MAX may not be defined before it is used in
>> io_blksize. I think you can just move the io_blksize function below
>> the later definition of MAX to fix this.
>
> Thanks for the heads up.
> Moving it "down" does sound like the right thing to do,
> but we should document which compiler/version is complaining about the
> current set-up.  Can you provide details?

The OS is OpenSolaris and the compiler is gcc 3.4, but it probably
affects any compiler and other Solaris versions. On Solaris MAX is
defined in sys/sysmacros.h which never gets included (on Linux it's in
sys/param.h which does get included).

-- David