Re: coreutils 7.1.49-ebb9 FTB sparc/Solaris, AIX

[Jim Meyering]

Matthew Woehlke wrote:
> (Please don't miss the AIX error at the bottom that isn't another
> decl-after-stmt.)
>
> Jim Meyering wrote:
>> Thanks for the report.
>> That's a statement-before-decl:
>> [snip]
>
> It's not be the only one.

It's probably the only one in gnulib.

> Ok, first, we'll try the patch:
> patching file remove.c

You're welcome to do this on your own, but it will take at least a few
more requests to support old compilers (with explanation why it's required)
before I spend time on c99-to-c89 again.

...
> So... remaining (decl-after-stmt) problems:
...
> Time to say "I told you so" yet? ;-)

You can say that as much as you want ;-)
But so far, you're the only one who seems to care about such
compilers.

> (<http://permalink.gmane.org/gmane.comp.lib.gnulib.bugs/16689> and
> elsewhere in the thread...) Apparently "maybe not ever" was defined as
> "before this week" :-). I've been updating my toolchains across the
> board. And... so far coreutils has been the only major c89-violator.
>
> Actually, I am a little confused, configure picked '-qlanglvl=ansi'
> but 'stdc99' and 'extc99' are available. (But I don't think that helps
> sparc/Solaris for which my only compilers - including gcc, apparently
> -
> are ancient.)
>
> Also, here is a different (AIX-only) error:
>
> cc -qlanglvl=ansi -qlanglvl=ansi   -g   -o ln ln.o libver.a
> ../lib/libcoreutils.a /home/install/gnu/rs6000_aix/lib/libintl.a
> -lpthread -lc ../lib/libcoreutils.a
> source='ls.c' object='ls.o' libtool=no \
>         DEPDIR=.deps depmode=aix /bin/sh ../build-aux/depcomp \
>         cc -qlanglvl=ansi -qlanglvl=ansi  -I. -I../lib  -I../lib
> -I/home/install/gnu/rs6000_aix/include   -g -c ls.c
> "ls.c", line 715.8: 1506-112 (E) Duplicate type qualifier "volatile"
> ignored.
> "ls.c", line 719.8: 1506-112 (E) Duplicate type qualifier "volatile"
> ignored.
> make[3]: *** [ls.o] Error 1
>
> I just ran into this also with some other package (possibly gettext or
> subversion*); might call for a fix at a higher level (gnulib or
> autoconf?). sig_atomic_t is already volatile on AIX (I checked last
> time) so the extra 'volatile' should just be dropped. Maybe something
> like:
>
> #if SIG_ATOMIC_T_IS_VOLATILE
> #define SIG_ATOMIC_T_VOLATILE sig_atomic_t
> #else
> #define SIG_ATOMIC_T_VOLATILE volatile sig_atomic_t
> #endif

We really don't want to impose that on every application
that uses sig_atomic_t.

Can you find out where they define or typedef sig_atomic_t?
Maybe we can work around it in a more global manner.