Re: [PATCH] stdbuf work in progress

[Pádraig Brady]

Jim Meyering wrote:
> Pádraig Brady wrote:
>> Latest iteration of stdbuf command.
>>
>> Notes:
>>  * It installs an unversioned shared lib to PKGLIBDIR
>>    (/usr/local/lib/coreutils by default). This is searched
>>    for by stdbuf itself rather than relying on the system,
>>    which allows us to select the uninstalled lib alongside
>>    the stdbuf binary when running tests for example.
>>  * Controlling fully buffered mode doesn't work with glibc-2.7:
>>    http://sources.redhat.com/bugzilla/show_bug.cgi?id=10108
>>  * It only installs to ELF systems with GCC currently
>>    (I'm not using libtool at present).
>>
> ...
> Thanks for all the work.
> Preliminary, superficial, feedback:
> 
>   - adjust spacing before parens, e.g.,
> 
>       > +  free(libstdbuf);
>       > +
>       > +  ret = putenv(LD_PRELOAD);
> 
>     easiest for new files like this is just to filter though "indent 
> --no-tabs"

fixed (lots more of that sorry).

> 
>   - don't use // comment introducer.  Here's one; there are others:
> 
>       > +#define LIB_NAME "libstdbuf.so" //FIXME: don't hardcode

also fixed

> 
>   - Ewww.  use ASCII apostrophe, not multi-byte in texi source:
> 
>       > +don\342\200\231t use streams for I/O, and are thus unaffected.

Eek. I must have copied and pasted from the output of man.

cheers,
Pádraig.