Re: 8.0beta : missing umount at end of tests

[Jim Meyering]

Gilles Espinasse wrote:
...
> I have tested with automated LFS script jhalf and it look to work there
...

I've gone ahead and pushed this change:

>From c695781753fdb3eceb78afdd947b86501209b2f2 Mon Sep 17 00:00:00 2001
From: Jim Meyering <address@hidden>
Date: Mon, 19 Oct 2009 09:11:08 +0200
Subject: [PATCH] tests: rm/one-file-system: work around umount failure

* tests/rm/one-file-system (cleanup_): Unmount a/b, rather than
"$other_partition_tmpdir", to accommodate those who link /etc/mtab
to /proc/mounts.  Reported by Gilles Espinasse in
http://thread.gmane.org/gmane.comp.gnu.coreutils.bugs/18508
---
 THANKS                   |    1 +
 tests/rm/one-file-system |    5 ++++-
 2 files changed, 5 insertions(+), 1 deletions(-)

diff --git a/THANKS b/THANKS
index 29013f6..5efe2fa 100644
--- a/THANKS
+++ b/THANKS
@@ -210,6 +210,7 @@ Geoff Whale                         address@hidden
 Gerald Pfeifer                      address@hidden
 Gerhard Poul                        address@hidden
 Germano Leichsenring                address@hidden
+Gilles Espinasse                    address@hidden
 Glen Lenker                         address@hidden
 Göran Uddeborg                      address@hidden
 Guochun Shi                         address@hidden
diff --git a/tests/rm/one-file-system b/tests/rm/one-file-system
index c8e11eb..db00a5b 100755
--- a/tests/rm/one-file-system
+++ b/tests/rm/one-file-system
@@ -27,7 +27,10 @@ require_root_
 # If used, these must *follow* test-lib.sh.
 cleanup_()
 {
-  umount "$other_partition_tmpdir"
+  # When you take the undesirable shortcut of making /etc/mtab a link
+  # to /proc/mounts, unmounting "$other_partition_tmpdir" would fail.
+  # So, here we unmount a/b instead.
+  umount a/b
   rm -rf "$other_partition_tmpdir"
 }
 . "$abs_srcdir/other-fs-tmpdir"
--
1.6.5.2.344.ga473e