[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] tail: don't call fstat on an uninitialized FD
|
From: |
Pádraig Brady |
|
Subject: |
Re: [PATCH] tail: don't call fstat on an uninitialized FD |
|
Date: |
Fri, 11 Dec 2009 11:47:14 +0000 |
|
User-agent: |
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.5) Gecko/20091204 Thunderbird/3.0 |
On 11/12/09 11:18, Jim Meyering wrote:
Last-minute testing found a minor problem.
Here's the fix I'm considering:
Looks good.
tail_file() only sets .fd in the "forever" case,
so short circuiting the check is both
faster and also now correct.