Re: [PATCH] src/sort.c: assert on temp.text before calling memcpy()

bug-coreutils

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] src/sort.c: assert on temp.text before calling memcpy()

From:	Pádraig Brady
Subject:	Re: [PATCH] src/sort.c: assert on temp.text before calling memcpy()
Date:	Wed, 06 Jan 2010 10:13:23 +0000
User-agent:	Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.5) Gecko/20091204 Thunderbird/3.0

That looks wrong.
Should memcpy() be marked as nonnull as the length can be 0?
In any case we don't want to be asserting in such cases,
rather just doing:

if (temp.text)
  memcpy (...)

[Prev in Thread]

Current Thread

[Next in Thread]

[PATCH] src/sort.c: assert on temp.text before calling memcpy(), Kovarththanan Rajaratnam, 2010/01/05
- Re: [PATCH] src/sort.c: assert on temp.text before calling memcpy(), Pádraig Brady <=
  - Re: [PATCH] src/sort.c: assert on temp.text before calling memcpy(), Kovarththanan Rajaratnam, 2010/01/06
    - Re: [PATCH] src/sort.c: assert on temp.text before calling memcpy(), Pádraig Brady, 2010/01/06
- Re: [PATCH] src/sort.c: assert on temp.text before calling memcpy(), Kamil Dudka, 2010/01/06

Prev by Date: [PATCH] build: require newer versions of automake and autoconf
Next by Date: Re: coreutils-7.2.5 - factor
Previous by thread: [PATCH] src/sort.c: assert on temp.text before calling memcpy()
Next by thread: Re: [PATCH] src/sort.c: assert on temp.text before calling memcpy()
Index(es):
- Date
- Thread