[PATCH] tests: don't silently skip the sort-version tests

[Jim Meyering]

Surprise!  We've been silently skipping the sort --version-sort (-V) tests.
The behavior of bash via /bin/sh (same for zsh and dash, though without
the warning) is probably POSIX-conforming, but this example illustrates
why it would be better to emulate openBSD's /bin/sh.

This will be in 8.4; if sort -V doesn't work, we want to know.

>From 3b498ba1410d9730782db439db27e85ff20d0e56 Mon Sep 17 00:00:00 2001
From: Jim Meyering <address@hidden>
Date: Wed, 13 Jan 2010 10:19:58 +0100
Subject: [PATCH] tests: don't silently skip the sort-version tests

* tests/misc/sort-version: Don't use <<- and indented here-doc contents.
s/<<-/<</ and unindent the here-document contents.  Otherwise,
bash would ignore the indented delimiter and use EOF, thus silently
skipping this test.  OpenBSD5.4's shell reported the failure:
  $ printf 'cat<<-x\n foo\n x\n'|sh
  sh: <stdin>[4]: here document `x' unclosed
  [Exit 1]
by contrast, bash warns but still exits successfully:
  $ printf 'cat<<-x\n foo\n x\n'|bash && echo you lose
  bash: line 3: warning: here-document at line 1 delimited by \
    end-of-file (wanted `x')
   foo
   x
  you lose
---
 tests/misc/sort-version |  160 +++++++++++++++++++++++-----------------------
 1 files changed, 80 insertions(+), 80 deletions(-)

diff --git a/tests/misc/sort-version b/tests/misc/sort-version
index d80ea7b..741ee8b 100755
--- a/tests/misc/sort-version
+++ b/tests/misc/sort-version
@@ -23,87 +23,87 @@ fi

 . $srcdir/test-lib.sh

-cat > in <<- _EOF_
-        gcc-c++-10.fc9.tar.gz
-        gcc-c++-10.8.12-0.7rc2.fc9.tar.bz2
-        glibc-2-0.1.beta1.fc10.rpm
-        glibc-common-5-0.2.beta2.fc9.ebuild
-        glibc-common-5-0.2b.deb
-        glibc-common-11b.ebuild
-        glibc-common-11-0.6rc2.ebuild
-        libstdc++-0.5.8.11-0.7rc2.fc10.tar.gz
-        libstdc++-4a.fc8.tar.gz
-        libstdc++-4.10.4.20040204svn.rpm
-        libstdc++-devel-3.fc8.ebuild
-        libstdc++-devel-3a.fc9.tar.gz
-        libstdc++-devel-8.fc8.deb
-        libstdc++-devel-8.6.2-0.4b.fc8
-        nss_ldap-1-0.2b.fc9.tar.bz2
-        nss_ldap-1-0.6rc2.fc8.tar.gz
-        nss_ldap-1.0-0.1a.tar.gz
-        nss_ldap-10beta1.fc8.tar.gz
-        nss_ldap-10.11.8.6.20040204cvs.fc10.ebuild
-        string start 5.0.0 end of str
-        string start 5.1.0 end of str
-        string start 5.10.0 end of str
-        string start 5.2.0 end of str
-        string start 5.20.0 end of str
-        string start 5.3.0 end of str
-        string start 5.30.0 end of str
-        string start 5.4.0 end of str
-        string start 5.40.0 end of str
-        string start 5.5.0 end of str
-        string start 5.50.0 end of str
-        string start 5.6.0 end of str
-        string start 5.60.0 end of str
-        string start 5.7.0 end of str
-        string start 5.70.0 end of str
-        string start 5.8.0 end of str
-        string start 5.80.0 end of str
-        string start 5.9.0 end of str
-        string start 5.90.0 end of str
-        _EOF_
+cat > in << _EOF_
+gcc-c++-10.fc9.tar.gz
+gcc-c++-10.8.12-0.7rc2.fc9.tar.bz2
+glibc-2-0.1.beta1.fc10.rpm
+glibc-common-5-0.2.beta2.fc9.ebuild
+glibc-common-5-0.2b.deb
+glibc-common-11b.ebuild
+glibc-common-11-0.6rc2.ebuild
+libstdc++-0.5.8.11-0.7rc2.fc10.tar.gz
+libstdc++-4a.fc8.tar.gz
+libstdc++-4.10.4.20040204svn.rpm
+libstdc++-devel-3.fc8.ebuild
+libstdc++-devel-3a.fc9.tar.gz
+libstdc++-devel-8.fc8.deb
+libstdc++-devel-8.6.2-0.4b.fc8
+nss_ldap-1-0.2b.fc9.tar.bz2
+nss_ldap-1-0.6rc2.fc8.tar.gz
+nss_ldap-1.0-0.1a.tar.gz
+nss_ldap-10beta1.fc8.tar.gz
+nss_ldap-10.11.8.6.20040204cvs.fc10.ebuild
+string start 5.0.0 end of str
+string start 5.1.0 end of str
+string start 5.10.0 end of str
+string start 5.2.0 end of str
+string start 5.20.0 end of str
+string start 5.3.0 end of str
+string start 5.30.0 end of str
+string start 5.4.0 end of str
+string start 5.40.0 end of str
+string start 5.5.0 end of str
+string start 5.50.0 end of str
+string start 5.6.0 end of str
+string start 5.60.0 end of str
+string start 5.7.0 end of str
+string start 5.70.0 end of str
+string start 5.8.0 end of str
+string start 5.80.0 end of str
+string start 5.9.0 end of str
+string start 5.90.0 end of str
+_EOF_

-cat > exp <<- _EOF_
-        gcc-c++-10.fc9.tar.gz
-        gcc-c++-10.8.12-0.7rc2.fc9.tar.bz2
-        glibc-2-0.1.beta1.fc10.rpm
-        glibc-common-5-0.2.beta2.fc9.ebuild
-        glibc-common-5-0.2b.deb
-        glibc-common-11b.ebuild
-        glibc-common-11-0.6rc2.ebuild
-        libstdc++-0.5.8.11-0.7rc2.fc10.tar.gz
-        libstdc++-4a.fc8.tar.gz
-        libstdc++-4.10.4.20040204svn.rpm
-        libstdc++-devel-3.fc8.ebuild
-        libstdc++-devel-3a.fc9.tar.gz
-        libstdc++-devel-8.fc8.deb
-        libstdc++-devel-8.6.2-0.4b.fc8
-        nss_ldap-1-0.2b.fc9.tar.bz2
-        nss_ldap-1-0.6rc2.fc8.tar.gz
-        nss_ldap-1.0-0.1a.tar.gz
-        nss_ldap-10beta1.fc8.tar.gz
-        nss_ldap-10.11.8.6.20040204cvs.fc10.ebuild
-        string start 5.0.0 end of str
-        string start 5.1.0 end of str
-        string start 5.2.0 end of str
-        string start 5.3.0 end of str
-        string start 5.4.0 end of str
-        string start 5.5.0 end of str
-        string start 5.6.0 end of str
-        string start 5.7.0 end of str
-        string start 5.8.0 end of str
-        string start 5.9.0 end of str
-        string start 5.10.0 end of str
-        string start 5.20.0 end of str
-        string start 5.30.0 end of str
-        string start 5.40.0 end of str
-        string start 5.50.0 end of str
-        string start 5.60.0 end of str
-        string start 5.70.0 end of str
-        string start 5.80.0 end of str
-        string start 5.90.0 end of str
-        _EOF_
+cat > exp << _EOF_
+gcc-c++-10.fc9.tar.gz
+gcc-c++-10.8.12-0.7rc2.fc9.tar.bz2
+glibc-2-0.1.beta1.fc10.rpm
+glibc-common-5-0.2.beta2.fc9.ebuild
+glibc-common-5-0.2b.deb
+glibc-common-11b.ebuild
+glibc-common-11-0.6rc2.ebuild
+libstdc++-0.5.8.11-0.7rc2.fc10.tar.gz
+libstdc++-4a.fc8.tar.gz
+libstdc++-4.10.4.20040204svn.rpm
+libstdc++-devel-3.fc8.ebuild
+libstdc++-devel-3a.fc9.tar.gz
+libstdc++-devel-8.fc8.deb
+libstdc++-devel-8.6.2-0.4b.fc8
+nss_ldap-1-0.2b.fc9.tar.bz2
+nss_ldap-1-0.6rc2.fc8.tar.gz
+nss_ldap-1.0-0.1a.tar.gz
+nss_ldap-10beta1.fc8.tar.gz
+nss_ldap-10.11.8.6.20040204cvs.fc10.ebuild
+string start 5.0.0 end of str
+string start 5.1.0 end of str
+string start 5.2.0 end of str
+string start 5.3.0 end of str
+string start 5.4.0 end of str
+string start 5.5.0 end of str
+string start 5.6.0 end of str
+string start 5.7.0 end of str
+string start 5.8.0 end of str
+string start 5.9.0 end of str
+string start 5.10.0 end of str
+string start 5.20.0 end of str
+string start 5.30.0 end of str
+string start 5.40.0 end of str
+string start 5.50.0 end of str
+string start 5.60.0 end of str
+string start 5.70.0 end of str
+string start 5.80.0 end of str
+string start 5.90.0 end of str
+_EOF_

 sort --sort=version -o out in || fail=1
 compare exp out || fail=1
--
1.6.6.511.gf46c4