[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] maint: fix an inconsequential mem leak in join
From: |
Jim Meyering |
Subject: |
Re: [PATCH] maint: fix an inconsequential mem leak in join |
Date: |
Wed, 27 Jan 2010 17:18:19 +0100 |
Pádraig Brady wrote:
> valgrind was complaining about definite mem leaks in `join`
> so I refactored the offending code a little and removed the
> inconseqential leak (which may mask real leaks in future).
...
> Subject: [PATCH] maint: fix an inconsequential mem leak in join
>
> * src/join.c (join): Refactor the code that checks for misorder
> at the tail of the files. The most significant change here is
> that freeline() is called thus silencing a valgrind warning about
> a definite but inconseqential memory leak.
> (freeline): Make more general by doing nothing when passed NULL,
> and setting freed pointers to NULL.
Thanks. That had been an annoyance when looking at leak summaries.