[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#5958: Sort-8.4 bug
From: |
Jim Meyering |
Subject: |
bug#5958: Sort-8.4 bug |
Date: |
Tue, 20 Apr 2010 18:55:08 +0200 |
Pádraig Brady wrote:
> I've changed it around in the attached patch so that
> we consistently use zero based limits throughout the code.
> I'll push this later on tonight unless there are objections.
...
> This regression was introduced in commit 224a69b5, 2009-02-24,
> "sort: Fix two bugs with determining the end of field".
> The specific regression being that we include 1 field too many when
> an end field is specified using obsolescent key syntax (+POS -POS).
>
> * src/sort.c (main): When processing obsolescent format key specifications,
> normalize eword to a zero based count when no specific end char is given
> for an end field. This matches what's done when keys are specified with -k.
> * tests/misc/sort: Add a few more tests for the obsolescent key formats,
> with test 07i being the particular failure addressed by this change.
> * THANKS: Add Alan Curry who precisely identified the issue.
> * NEWS: Mention the fix.
> Reported by Santiago RodrÃguez
...
> +#ensure obsolescent key limits are handled correctly
Nicely done. Thanks!
s/en/ en/