[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#8845: build failure on HP-UX 11.31
|
From: |
Eric Blake |
|
Subject: |
bug#8845: build failure on HP-UX 11.31 |
|
Date: |
Mon, 13 Jun 2011 08:40:59 -0600 |
|
User-agent: |
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.17) Gecko/20110419 Red Hat/3.1.10-1.el6_0 Mnenhy/0.8.3 Thunderbird/3.1.10 |
On 06/13/2011 03:23 AM, Jim Meyering wrote:
> +++ b/lib/file-set.h
> @@ -6,7 +6,10 @@
>
> extern void record_file (Hash_table *ht, char const *file,
> struct stat const *stats)
> - __attribute__ ((nonnull (2, 3)));
> +#if defined __GNUC__ && ((__GNUC__ == 3 && __GNUC_MINOR__ >= 3) || __GNUC__
> > 3)
> + __attribute__ ((nonnull (2, 3)))
> +#endif
> +;
I'm not a fan of in-declaration #ifdefs; can we rewrite this to:
#if defined __GNUC__ && ((__GNUC__ == 3 && __GNUC_MINOR__ >= 3) ||
__GNUC__ > 3)
# define ATTRIBUTE_NONNULL(a) __attribute__ ((nonnull (a)))
#else
# define ATTRIBUTE_NONNULL(a) /* ignored */
#endif
extern void record_file (Hash_table *ht, char const *file,
struct stat const *stats)
ATTRIBUTE_NONNULL(2) ATTRIBUTE_NONNULL(3);
--
Eric Blake address@hidden +1-801-349-2682
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature