[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#11816: sort -o: error comes late if opening the outfile fails
From: |
Pádraig Brady |
Subject: |
bug#11816: sort -o: error comes late if opening the outfile fails |
Date: |
Mon, 02 Jul 2012 21:24:48 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:6.0) Gecko/20110816 Thunderbird/6.0 |
On 07/02/2012 06:55 PM, Jim Meyering wrote:
> Pádraig Brady wrote:
>> ...
>> diff --git a/tests/misc/sort-exit-early b/tests/misc/sort-exit-early
> ...
>> +test $? == 124 && fail=1
>> +
>> +# Check all inputs are readable before starting to sort
>> +# Also ensure the output isn't created in this case
>> +touch output
>> +chmod a-r output
>> +timeout 10 sort -o typo - output && fail=1
>> +test $? == 124 && fail=1
>
> "make syntax-check" dinged these:
>
> tests/misc/sort-exit-early:24:test $? == 124 && fail=1
> tests/misc/sort-exit-early:31:test $? == 124 && fail=1
> maint.mk: use "test x = x", not "test x == x"
> make: *** [sc_prohibit_test_double_equal] Error 1
>
>
> Here's a fix for a formatting nit in the sources:
>
> static void
> -check_inputs (char * const *files, size_t nfiles)
> +check_inputs (char *const *files, size_t nfiles)
>
> Otherwise, it all looks fine.
> Thanks again.
Pushed.
thanks for the careful review.
Pádraig.