bug#14152: [PATCH] build: use 'chmod a-w' instead of 'chmod -w'

[Pádraig Brady]

On 04/07/2013 10:59 AM, Enrico Scholz wrote:
> Pádraig Brady <address@hidden> writes:
> 
>>>> What system does the build fail on as a matter of interest.
>>>
>>> This will occur on any system that has umask set to 022.  Here is an 
>>> example:
>>>
>>>   $ umask 022
>>>   $ touch foo
>>>   $ chmod ug+w foo
>>>   $ chmod -w foo
>>>   chmod: foo: new permissions are r--rw-r--, not r--r--r--
>>>   $ echo $?
>>>   1
>>
>> But if the umask is 022, then those write bits shouldn't be set anyway?
> 
> These bits can be set due to various reasons; e.g.
> 
> $ mkdir /tmp/foo
> $ setfacl -m d:m:rwx /tmp/foo
> 
> $ umask 022
> $ touch /tmp/foo/x
> $ chmod -w /tmp/foo/x
> chmod: /tmp/foo/x: new permissions are r--rw-r--, not r--r--r--
> 
> 
> I use such a setup (posix defaults acls) to build foreign software as a
> special user while allowing working on the software (--> editing) as the
> normal user.

Excellent, thanks for the clarification.
I've adjusted the commit message as follows:

    build: fix man page build failure with some permissions setups

    Use the more portable 'chmod a-w', instead of the 'chmod -w' form.
    The latter is not always supported.  Also its operation is
    dependent on umask controlling the permissions bits for new files,
    which is not the case in the presence of POSIX default ACLs for e.g.
    In that case, chmod may print a warning like the following, and
    exit with failure status:

    chmod: man/hostid.1-t: new permissions are r--rw-r--, not r--r--r--

    * man/local.mk: s/-w/a-w/

thanks,
Pádraig.