>From 76bd83186496b3ed45adef598c1eab9797852d47 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?P=C3=A1draig=20Brady?= Date: Wed, 5 Mar 2014 15:14:07 +0000 Subject: [PATCH] tests: fix false failure in nohup.sh in non tty builds * tests/misc/nohup.sh: When building without a controlling tty, an exec failure is triggered in a subshell, which causes POSIX shells to immediately exit the subshell. This was brought to notice by the newly conforming bash 4.3. Fixes http:/bugs.gnu.org/16940 --- tests/misc/nohup.sh | 5 +++++ 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/tests/misc/nohup.sh b/tests/misc/nohup.sh index 6d2b515..015e84f 100755 --- a/tests/misc/nohup.sh +++ b/tests/misc/nohup.sh @@ -63,6 +63,11 @@ rm -f nohup.out err # to stderr must be fatal. Requires stdout to be terminal. if test -w /dev/full && test -c /dev/full; then ( + # POSIX shells immediately exit the subshell on exec error. + # So check we can write to /dev/tty before the exec, which + # isn't possible if we've no controlling tty for example. + >/dev/tty || exit 0 + exec >/dev/tty test -t 1 || exit 0 nohup echo hi 2> /dev/full -- 1.7.7.6