[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#15992: 'ls' ignores term capabilities when generating color.
From: |
Pádraig Brady |
Subject: |
bug#15992: 'ls' ignores term capabilities when generating color. |
Date: |
Wed, 16 Apr 2014 16:56:04 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 |
On 04/16/2014 02:51 PM, Guilherme de Almeida Suckevicz wrote:
> Hi Pádraig,
>
> I made a patch for this issue according to the tips above.
> I hope that is ok!
>
> address@hidden build]$ diff ../src/ls.c ../src/ls-orig.c
Note the patch is reversed, also we prefer unified format,
also we'd much prefer a patch against the git repo.
For general notes on supplying patches see:
http://git.sv.gnu.org/gitweb/?p=coreutils.git;a=blob;f=README-hacking;hb=HEAD
> 2372,2382c2339
> < {
> < /* If COLORTERM is not set, check if the term type is know. */
> < if (getenv ("COLORTERM") == NULL)
> < {
> < if (! know_term_type ())
> < {
> < print_with_color = false;
> < return;
> < }
> < }
you want a return here too
> < }
I've cleaned up the patch and added a test.
If you're Ok with it I'll push.
thanks,
Pádraig.
ls-dumb-term.patch
Description: Text Data