bug-coreutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#36831: enhance 'directory not empty' message


From: Paul Eggert
Subject: bug#36831: enhance 'directory not empty' message
Date: Mon, 29 Jul 2019 18:50:46 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0

On 7/29/19 1:28 AM, Assaf Gordon wrote:
+      if (rename_errno == ENOTEMPTY || rename_errno == EEXIST)
+        {
+          error (0, 0, _("cannot move %s to %s: Target directory not empty"),
+                 quoteaf_n (0, src_name), quoteaf_n (1, dst_name));

Although this is an improvement, it is not general enough, as other errno values are relevant only for the destination. Better would be to have a special case for errno values that matter only for the destination, and use the existing code for errno values where we don't know whether the problem is the source or the destination. Something like the attached, say.


Attachment: mv.diff
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]