[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#44235: [PATCH] dd: drop old workaround for lseek() bug in Linux kern
From: |
Pádraig Brady |
Subject: |
bug#44235: [PATCH] dd: drop old workaround for lseek() bug in Linux kernel |
Date: |
Mon, 26 Oct 2020 13:11:59 +0000 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:82.0) Gecko/20100101 Thunderbird/82.0 |
On 26/10/2020 10:44, Kamil Dudka wrote:
The workaround triggers warnings with new kernel versions in case
a user does not have sufficient privileges for the MTIOCGET ioctl.
* src/dd.c (skip_via_lseek): Drop wrapper function no longer needed.
(skip): Use lseek() directly.
(advance_input_after_read_error): Use lseek() directly.
Reported-by: Nir Soffer
Bug: https://bugzilla.redhat.com/1876840
To clarify, the kernel is warning, not dd.
In general the kernel should be disallowing rather than warning I think.
But yes this is old code that should no longer be needed.
I'll apply the patch.
thanks,
Pádraig