bug#45321: file -b reports PHP file as C++ file

bug-coreutils
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#45321: file -b reports PHP file as C++ file

From:	Jeffrey Walton
Subject:	bug#45321: file -b reports PHP file as C++ file
Date:	Sat, 19 Dec 2020 03:37:40 -0500
Hi Everyone,

I'm not sure if this is expected. I'm working on CentOS 7, x86_64,
fully patched.

I expected to see the PHP file below classified as a PHP script, like:

    # file -b rest.php
    PHP script, ASCII text

I did not see any Gotcha's listed for the file command at
https://www.pixelbeat.org/docs/coreutils-gotchas.html.

Jeff

    # file --version
    file-5.11
    magic file from /etc/magic:/usr/share/misc/magic

    # ls -Al profileinfo.php
    -rw-r----- 1 root apache 12531 Sep 24 17:35 profileinfo.php

    # file -b profileinfo.php
    C++ source, UTF-8 Unicode text

# cat profileinfo.php
<?php
/**
 * Simple interface for displaying request profile data stored in
 * the wikis' primary database.
 *
 * See also https://www.mediawiki.org/wiki/Manual:Profiling.
 *
 * To add profiling information to the database:
 *
 * - set $wgProfiler['class'] in LocalSetings.php to a Profiler class
other than ProfilerStub.
 * - set $wgProfiler['output'] to 'db' to force the profiler to save its the
 *   information in the database.
 * - apply the maintenance/archives/patch-profiling.sql patch to the database.
 * - set $wgEnableProfileInfo to true.
 *
 * Copyright 2005 Kate Turner.
 *
 * Permission is hereby granted, free of charge, to any person obtaining a copy
 * of this software and associated documentation files (the "Software"), to deal
 * in the Software without restriction, including without limitation the rights
 * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
 * copies of the Software, and to permit persons to whom the Software is
 * furnished to do so, subject to the following conditions:
 *
 * The above copyright notice and this permission notice shall be included in
 * all copies or substantial portions of the Software.
 *
 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
 * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
 * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
 * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
 * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
 * SOFTWARE.
 *
 * @file
 */

// This endpoint is supposed to be independent of request cookies and other
// details of the session. Enforce this constraint with respect to session use.
define( 'MW_NO_SESSION', 1 );

define( 'MW_ENTRY_POINT', 'profileinfo' );

ini_set( 'zlib.output_compression', 'off' );

require __DIR__ . '/includes/WebStart.php';

header( 'Content-Type: text/html; charset=utf-8' );

?>
<!DOCTYPE html>
<html>
<head>
    <meta charset="UTF-8" />
    <title>Profiling data</title>
    <style>
        /* noc.wikimedia.org/base.css */

        * {
            margin: 0;
            padding: 0;
        }

        body {
            padding: 0.5em 1em;
            background: #fff;
            font: 14px/1.6 sans-serif;
            color: #333;
        }

        p, ul, ol, table {
            margin: 0.5em 0;
        }

        a {
            color: #0645AD;
            text-decoration: none;
        }

        a:hover {
            text-decoration: underline;
        }

        /*!
         * Bootstrap v2.1.1
         *
         * Copyright 2012 Twitter, Inc
         * Licensed under the Apache License v2.0
         * http://www.apache.org/licenses/LICENSE-2.0
         *
         * Designed and built with all the love in the world @twitter
by @mdo and @fat.
         */

        table {
            max-width: 100%;
            background-color: transparent;
            border-collapse: collapse;
            border-spacing: 0;
        }

        .table {
            width: 100%;
            margin-bottom: 20px;
        }

        .table th,
        .table td {
            padding: 0.1em;
            text-align: left;
            vertical-align: top;
            border-top: 1px solid #ddd;
        }

        .table th {
            font-weight: bold;
        }

        .table thead th {
            vertical-align: bottom;
        }

        .table thead:first-child tr:first-child th,
        .table thead:first-child tr:first-child td {
            border-top: 0;
        }

        .table tbody + tbody {
            border-top: 2px solid #ddd;
        }

        .table-condensed th,
        .table-condensed td {
            padding: 4px 5px;
        }

        .table-striped tbody tr:nth-child(odd) td,
        .table-striped tbody tr:nth-child(odd) th {
            background-color: #f9f9f9;
        }

        .table-hover tbody tr:hover td,
        .table-hover tbody tr:hover th {
            background-color: #f5f5f5;
        }

        hr {
            margin: 20px 0;
            border: 0;
            border-top: 1px solid #eee;
            border-bottom: 1px solid #fff;
        }
    </style>
</head>
<body>
<?php

if ( !$wgEnableProfileInfo ) {
    echo '<p>Disabled</p>'
        . '</body></html>';
    exit( 1 );
}

$dbr = wfGetDB( DB_REPLICA );

if ( !$dbr->tableExists( 'profiling' ) ) {
    echo '<p>No <code>profiling</code> table exists, so we can\'t show
you anything.</p>'
        . '<p>If you want to log profiling data, enable
<code>$wgProfiler[\'output\'] = \'db\'</code>'
        . ' in LocalSettings.php and run <code>maintenance/update.php</code> to'
        . ' create the profiling table.'
        . '</body></html>';
    exit( 1 );
}

$expand = [];
if ( isset( $_REQUEST['expand'] ) ) {
    foreach ( explode( ',', $_REQUEST['expand'] ) as $f ) {
        $expand[$f] = true;
    }
}
wfDeprecated( 'profileinfo.php', '1.34' );

// phpcs:ignore Squiz.Classes.ValidClassName.NotCamelCaps
class profile_point {

    public $name;
    public $count;
    public $time;
    public $children;

    public static $totaltime, $totalmemory, $totalcount;

    public function __construct( $name, $count, $time, $memory ) {
        $this->name = $name;
        $this->count = $count;
        $this->time = $time;
        $this->memory = $memory;
        $this->children = [];
    }

    public function add_child( $child ) {
        $this->children[] = $child;
    }

    public function display( $expand, $indent = 0.0 ) {
        usort( $this->children, 'compare_point' );

        $ex = isset( $expand[$this->name()] );

        $anchor = str_replace( '"', '', $this->name() );

        if ( !$ex ) {
            if ( count( $this->children ) ) {
                $url = getEscapedProfileUrl( false, false, $expand + [
$this->name() => true ] );
                $extet = " <a id=\"{$anchor}\"
href=\"{$url}#{$anchor}\">[+]</a>";
            } else {
                $extet = '';
            }
        } else {
            $e = [];
            foreach ( $expand as $name => $ep ) {
                if ( $name != $this->name() ) {
                    $e += [ $name => $ep ];
                }
            }
            $url = getEscapedProfileUrl( false, false, $e );
            $extet = " <a id=\"{$anchor}\" href=\"{$url}#{$anchor}\">[–]</a>";
        }
        ?>
    <tr>
        <th>
            <div style="margin-left: <?php echo (int)$indent; ?>em;">
                <?php echo htmlspecialchars( str_replace( ',', ', ',
$this->name() ) ) . $extet ?>
            </div>
        </th>
        <?php // phpcs:disable
Generic.Files.LineLength,Generic.PHP.NoSilencedErrors ?>
        <td class="mw-profileinfo-timep"><?php echo @wfPercent(
$this->time() / self::$totaltime * 100 ); ?></td>
        <td class="mw-profileinfo-memoryp"><?php echo @wfPercent(
$this->memory() / self::$totalmemory * 100 ); ?></td>
        <td class="mw-profileinfo-count"><?php echo $this->count(); ?></td>
        <td class="mw-profileinfo-cpr"><?php echo round( sprintf(
'%.2f', $this->callsPerRequest() ), 2 ); ?></td>
        <td class="mw-profileinfo-tpc"><?php echo round( sprintf(
'%.2f', $this->timePerCall() ), 2 ); ?></td>
        <td class="mw-profileinfo-mpc"><?php echo round( sprintf(
'%.2f', $this->memoryPerCall() / 1024 ), 2 ); ?></td>
        <td class="mw-profileinfo-tpr"><?php echo @round( sprintf(
'%.2f', $this->time() / self::$totalcount ), 2 ); ?></td>
        <td class="mw-profileinfo-mpr"><?php echo @round( sprintf(
'%.2f', $this->memory() / self::$totalcount / 1024 ), 2 ); ?></td>
        <?php // phpcs:enable ?>
    </tr>
        <?php
        if ( $ex ) {
            foreach ( $this->children as $child ) {
                $child->display( $expand, $indent + 2 );
            }
        }
    }

    public function name() {
        return $this->name;
    }

    public function count() {
        return $this->count;
    }

    public function time() {
        return $this->time;
    }

    public function memory() {
        return $this->memory;
    }

    public function timePerCall() {
        // phpcs:ignore Generic.PHP.NoSilencedErrors.Discouraged
        return @( $this->time / $this->count );
    }

    public function memoryPerCall() {
        // phpcs:ignore Generic.PHP.NoSilencedErrors.Discouraged
        return @( $this->memory / $this->count );
    }

    public function callsPerRequest() {
        // phpcs:ignore Generic.PHP.NoSilencedErrors.Discouraged
        return @( $this->count / self::$totalcount );
    }

    public function timePerRequest() {
        // phpcs:ignore Generic.PHP.NoSilencedErrors.Discouraged
        return @( $this->time / self::$totalcount );
    }

    public function memoryPerRequest() {
        // phpcs:ignore Generic.PHP.NoSilencedErrors.Discouraged
        return @( $this->memory / self::$totalcount );
    }

    public function fmttime() {
        return sprintf( '%5.02f', $this->time );
    }
}

function compare_point( profile_point $a, profile_point $b ) {
    // phpcs:ignore MediaWiki.NamingConventions.ValidGlobalName.wgPrefix
    global $sort;

    switch ( $sort ) {
        // Sorted ascending:
        case 'name':
            return strcmp( $a->name(), $b->name() );
        // Sorted descending:
        case 'time':
            return $b->time() <=> $a->time();
        case 'memory':
            return $b->memory() <=> $a->memory();
        case 'count':
            return $b->count() <=> $a->count();
        case 'time_per_call':
            return $b->timePerCall() <=> $a->timePerCall();
        case 'memory_per_call':
            return $b->memoryPerCall() <=> $a->memoryPerCall();
        case 'calls_per_req':
            return $b->callsPerRequest() <=> $a->callsPerRequest();
        case 'time_per_req':
            return $b->timePerRequest() <=> $a->timePerRequest();
        case 'memory_per_req':
            return $b->memoryPerRequest() <=> $a->memoryPerRequest();
    }
}

$sorts = [ 'time', 'memory', 'count', 'calls_per_req', 'name',
    'time_per_call', 'memory_per_call', 'time_per_req', 'memory_per_req' ];
$sort = 'time';
if ( isset( $_REQUEST['sort'] ) && in_array( $_REQUEST['sort'], $sorts ) ) {
    $sort = $_REQUEST['sort'];
}

$res = $dbr->select(
    'profiling',
    '*',
    [],
    'profileinfo.php',
    [ 'ORDER BY' => 'pf_name ASC' ]
);

$filter = $_REQUEST['filter'] ?? '';

?>
<form method="get" action="profileinfo.php">
    <p>
        <input type="text" name="filter" value="<?php echo
htmlspecialchars( $filter ); ?>">
        <input type="hidden" name="sort" value="<?php echo
htmlspecialchars( $sort ); ?>">
        <input type="hidden" name="expand" value="<?php
            echo htmlspecialchars( implode( ",", array_keys( $expand ) ) );
        ?>">
        <input type="submit" value="Filter">
    </p>
</form>

<table class="mw-profileinfo-table table table-striped table-hover">
    <thead>
    <tr>
        <th><a href="<?php
            echo getEscapedProfileUrl( false, 'name' );
        ?>">Name</a></th>
        <th><a href="<?php
            echo getEscapedProfileUrl( false, 'time' );
        ?>">Time (%)</a></th>
        <th><a href="<?php
            echo getEscapedProfileUrl( false, 'memory' );
        ?>">Memory (%)</a></th>
        <th><a href="<?php
            echo getEscapedProfileUrl( false, 'count' );
        ?>">Count</a></th>
        <th><a href="<?php
            echo getEscapedProfileUrl( false, 'calls_per_req' );
        ?>">Calls/req</a></th>
        <th><a href="<?php
            echo getEscapedProfileUrl( false, 'time_per_call' );
        ?>">ms/call</a></th>
        <th><a href="<?php
            echo getEscapedProfileUrl( false, 'memory_per_call' );
        ?>">kb/call</a></th>
        <th><a href="<?php
            echo getEscapedProfileUrl( false, 'time_per_req' );
        ?>">ms/req</a></th>
        <th><a href="<?php
            echo getEscapedProfileUrl( false, 'memory_per_req' );
        ?>">kb/req</a></th>
    </tr>
    </thead>
    <tbody>
    <?php
    profile_point::$totaltime = 0.0;
    profile_point::$totalcount = 0;
    profile_point::$totalmemory = 0.0;

    function getEscapedProfileUrl( $_filter = false, $_sort = false,
$_expand = false ) {
        // phpcs:ignore MediaWiki.NamingConventions.ValidGlobalName.wgPrefix
        global $filter, $sort, $expand;

        if ( $_expand === false ) {
            $_expand = $expand;
        }

        return htmlspecialchars(
            '?' .
                wfArrayToCgi( [
                    'filter' => $_filter ?: $filter,
                    'sort' => $_sort ?: $sort,
                    'expand' => implode( ',', array_keys( $_expand ) )
                ] )
        );
    }

    $points = [];
    $queries = [];
    $sqltotal = 0.0;

    /** @var profile_point|false $last */
    $last = false;
    foreach ( $res as $o ) {
        $next = new profile_point( $o->pf_name, $o->pf_count,
$o->pf_time, $o->pf_memory );
        if ( $next->name() == '-total' || $next->name() == 'main()' ) {
            profile_point::$totaltime = $next->time();
            profile_point::$totalcount = $next->count();
            profile_point::$totalmemory = $next->memory();
        }
        if ( $last !== false ) {
            if ( preg_match( '/^' . preg_quote( $last->name(), '/' ) .
'/', $next->name() ) ) {
                $last->add_child( $next );
                continue;
            }
        }
        $last = $next;
        if ( preg_match( '/^query: /', $next->name() ) || preg_match(
'/^query-m: /', $next->name() ) ) {
            $sqltotal += $next->time();
            $queries[] = $next;
        } else {
            $points[] = $next;
        }
    }

    $s = new profile_point( 'SQL Queries', 0, $sqltotal, 0 );
    foreach ( $queries as $q ) {
        $s->add_child( $q );
    }
    $points[] = $s;

    // phpcs:ignore Generic.PHP.NoSilencedErrors.Discouraged
    @usort( $points, 'compare_point' );

    foreach ( $points as $point ) {
        if ( strlen( $filter ) && !strstr( $point->name(), $filter ) ) {
            continue;
        }

        $point->display( $expand );
    }
    ?>
    </tbody>
</table>
<hr />
<p>Total time: <code><?php printf( '%5.02f', profile_point::$totaltime
); ?></code></p>

<p>Total memory: <code><?php printf( '%5.02f',
profile_point::$totalmemory / 1024 ); ?></code></p>
<hr />
</body>
</html>
[Prev in Thread]
Current Thread
[Next in Thread]
bug#45321: file -b reports PHP file as C++ file, Jeffrey Walton <=
- bug#45321: file -b reports PHP file as C++ file, Jeffrey Walton, 2020/12/19
  - bug#45321: file -b reports PHP file as C++ file, Pádraig Brady, 2020/12/19
    - bug#45321: file -b reports PHP file as C++ file, Jeffrey Walton, 2020/12/19
Prev by Date: bug#45258: mkdir man page unclear in describing -m flag
Next by Date: bug#45321: file -b reports PHP file as C++ file
Previous by thread: bug#45258: mkdir man page unclear in describing -m flag
Next by thread: bug#45321: file -b reports PHP file as C++ file
Index(es):
- Date
- Thread