bug-coreutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#63850: cp fails for files > 2 GB if copy offload is unsupported


From: Paul Eggert
Subject: bug#63850: cp fails for files > 2 GB if copy offload is unsupported
Date: Fri, 2 Jun 2023 23:05:24 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0

On 2023-06-02 09:31, Pádraig Brady wrote:
I'm not sure it was working correctly before 9.3 either.
Before 9.3 we would have switched from copy_file_range() to read()/write()

Actually, cp shouldn't have been using copy_file_range at all, as the code is supposed to never use copy_file_range unless the Linux kernel version is 5.3 or later. See m4/copy-file-range.m4 and lib/copy-file-range.c.

Since the bug is being reported against kernel 4.19, someone needs to investigate why the Gentoo build is using the copy_file_range syscall on that kernel. Either the Gentoo build isn't properly compiling the replacement function in coreutils/lib/copy-file-range.c, or the replacement function is incorrectly deciding that the kernel is new enough, or something like that.

We shouldn't need to fiddle with src/copy.c on this.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]