[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH resend] Wrong CRC with ASCII CRC for large files
|
From: |
Dominique Martinet |
|
Subject: |
Re: [PATCH resend] Wrong CRC with ASCII CRC for large files |
|
Date: |
Mon, 10 Apr 2023 09:25:54 +0900 |
Sergey Poznyakoff wrote on Fri, Apr 07, 2023 at 10:32:06AM +0200:
> Thanks for reporting that. I'm ashamed to have overlooked this issue.
It happens, I was just annoyed at the snark remark in the yocto
commit despite no visible attempt to send the patch again :)
> The original patch, while fixing the bug, inadvertently introduced
> another one: eventual read error was never caught
Indeed, if bytes_read become unsigned then it can never be negative.
Good catch & sorry for not checking before resending.
> so I installed this patch instead:
>
>
> http://git.savannah.gnu.org/cgit/cpio.git/commit/?id=a1b2f7871c3ae5113e0102b870b15ea06a8f0e3d
This looks good to me, thank you!
--
Dominique