[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
"cvs server" accepts but ignored --allow-root
From: |
Tim Riker |
Subject: |
"cvs server" accepts but ignored --allow-root |
Date: |
Wed, 09 Oct 2002 17:23:47 -0600 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.1) Gecko/20020913 Debian/1.1-1 |
It seems that --allow-root is not handled by cvs when using server.
I have found many FAQs on the net that indicate I should setup cvs over
ssh using something like:
no-port-forwarding,no-X11-forwarding,no-agent-forwarding,command="/usr/bin/cvs
--allow-root=/cvs/limited server" ssh-dss A...ys= timr@localhost
Which would then limit cvsroot to /cvs/limited. This is NOT the case.
cvs silently accepts the --allow-root, but does not process it. It DOES
process it if used with pserver.
Accepting the argument if it will not be handled is a bug.
Not handling the argument if it is accepted it also a bug.
As there are sites using this (or thinking they are using this) now, I
would strongly recommend it get added as a feature.
Documenting the non-feature and correctly reporting the error would
probably be tougher.
I would think a call to root_allow_ok() from server_root() and making
the "error 0" clause in root_allow_ok() be conditional on Pserver_Repos
would do the trick.
--
Tim Riker - http://rikers.org/ - TimR@Debian.org
Lineo CTO - Tim@Lineo.com - http://www.Lineo.com/
BZFlag maintainer - http://BZFlag.org/ - for fun!
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- "cvs server" accepts but ignored --allow-root,
Tim Riker <=