[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] includeopt-fix
From: |
Derek Robert Price |
Subject: |
Re: [PATCH] includeopt-fix |
Date: |
Wed, 28 May 2003 17:08:58 -0400 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.0.2) Gecko/20030208 Netscape/7.02 |
Alexey Mahotkin wrote:
> -# FIXME - the fact that compiling on my Linux 2.2.16 system finds
> -# /usr/include/error.h instead of $(top_srcdir)/src/error.h but
> -# everything compiles and tests anyhow implies that src/error.h may
> -# be unecessary now. Should look more deeply into this
If you delete #include "error.h" from savecwd.c, everything compiles ok
with just a warning:
/var/src/ccvs/lib/savecwd.c: In function `save_cwd':
/var/src/ccvs/lib/savecwd.c:63: warning: implicit declaration of function
`error'
So, maybe savecwd.[ch] should just be moved to src/, or error.[ch] to lib/,
to get rid of circular dependency between two directories. Or maybe just
leave everything alone. I do not see where there could be trouble.
With luck I'll be moving CVS to use an error.c from GNULIB in lib soon -
there are some issues with CVS specific code in our error.c, but GNULIB
has a hook for callbacks so I have high hopes. :)
<http://ccvs.cvshome.org/issues/show_bug.cgi?id=124>
2003-05-10 Alexey Mahotkin <alexm@hsys.msk.ru>
* Makefile.am: get rid of $(includeopt); -Isrc/ is ok, so remove
lengthy explanation.
Committed.
Derek
--
*8^)
Email: derek@ximbiot.com
Get CVS support at <http://ximbiot.com>!
--
I will not sell land in Florida.
I will not sell land in Florida.
I will not sell land in Florida...
- Bart Simpson on chalkboard, _The Simpsons_