|
From: | Derek Robert Price |
Subject: | Re: rdiff |
Date: | Thu, 05 Jun 2003 10:53:04 -0400 |
User-agent: | Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.0.2) Gecko/20030208 Netscape/7.02 |
Paul Edwards wrote:
"Derek Robert Price" <derek@ximbiot.com> wrote in message news:mailman.7283.1054740779.21513.bug-cvs@gnu.org...Regardless, I looked into it myself and I think the correct patch is more like the following:As well as that out/out2 goto, there is another thing that I think is required for closure. IIRC, at another site, I needed to change the output of rdiff because I needed to know the version number of the removed files, for input into something-else. I put in your patch, the out/out2 plus this one, and I tested it and everything worked fine. I didn't understand sanity.sh, but I did do tests on changes, additions and removals, to make sure that I got the results I expected, and they all worked. It's pretty good, that's what I need. Will you put it against cvs1-11-x-branch?
We don't commit without regression tests to prevent the bug from showing up again and I really don't have time to write the tests myself just now.
Please read ccvs/TESTS for information on how to write ccvs/src/sanity.sh tests. They aren't so hard. It amounts to a series of calls to `dotest <command> <expected output>' with some variables in the <expected output> to allow for differences in environment - paths, usernames, and the like. There is one main loop with a case statement with all the tests. Add an `rdiff-add-remove-nodiff)' case to that case statement & the calls to dotest after that. I'll clean it up if you can get it close.
Derek -- *8^) Email: derek@ximbiot.com Get CVS support at <http://ximbiot.com>! -- I used to think people were crazy to get tatoos. Nowadays, I envy them that clarity of thought. There was at least one point in their lives when they thought they knew what they were doing. They could walk into a tatoo parlor and say, "I want a big old pig, in red and black, with flames shooting out of its ass! And I want it right there! That's who I am!"
[Prev in Thread] | Current Thread | [Next in Thread] |