gnulib inclusion error exposed by Linux ppc64le build

[Georg Sauthoff]

Hello,

I'm the new Fedora datamash package maintainer.

This was reported previously on this list (cf.
https://lists.gnu.org/archive/html/bug-datamash/2022-03/msg00000.html),
but it's still an issue with tht latest Datamash 1.8 release.

See also https://bugzilla.redhat.com/show_bug.cgi?id=2056736 for
the old Fedora bug report.

Currently, Datamash 1.8 fails to build on Linux ppc64le because of how
the gnulib error module is integrated.

That means the following test fails there:

    FAIL: tests/datamash-error-msgs.pl

cf.  https://kojipkgs.fedoraproject.org//work/tasks/2782/99442782/build.log
via https://koji.fedoraproject.org/koji/taskinfo?taskID=99442782

My workaround for this is to simply delete that error module like this
after unpacking the source archive, because it isn't needed on Linux:

    rm lib/error.*

See also https://koji.fedoraproject.org/koji/taskinfo?taskID=99443708
for how a thus modified package build succeeds on ppc64le.

Of course, I prefer if this is getting fixed upstream.

Perhaps that error module isn't even needed anymore on any of the target
platforms you want to support.
Or, if you still want to include it, perhaps you can change configure
such that it's only (properly) included on non-Linux platforms.

---

Another thing, I noticed that Datamash now requires the makeinfo
program:

    + cd datamash-1.8
    + /usr/bin/make install 
DESTDIR=/builddir/build/BUILDROOT/datamash-1.8-1.fc39.ppc64le 
'INSTALL=/usr/bin/install -p'
    WARNING: version string 1.8-dirty is out of date;
    run '/usr/bin/make _version' to fix it
    /usr/bin/make  install-recursive
    make[1]: Entering directory '/builddir/build/BUILD/datamash-1.8'
    [..]
    rm -rf $backupdir; exit $rc
    /builddir/build/BUILD/datamash-1.8/build-aux/missing: line 81: makeinfo: 
command not found
    WARNING: 'makeinfo' is missing on your system.
             You should only need it if you modified a '.texi' file, or
             any other file indirectly affecting the aspect of the manual.
             You might want to install the Texinfo package:
             <https://www.gnu.org/software/texinfo/>
             The spurious makeinfo call might also be the consequence of
             using a buggy 'make' (AIX, DU, IRIX), in which case you might
             want to install GNU make:
             <https://www.gnu.org/software/make/>
    make[2]: Leaving directory '/builddir/build/BUILD/datamash-1.8'
    make[2]: *** [Makefile:3652: doc/datamash.info] Error 127
    make[1]: *** [Makefile:3901: install-recursive] Error 1
    make[1]: Leaving directory '/builddir/build/BUILD/datamash-1.8'
    make: *** [Makefile:4381: install] Error 2


This wasn't required in previous releases, Fedora builds with GNU make
and there aren't any manual files modified AFAICS.

See also:
https://kojipkgs.fedoraproject.org//work/tasks/1251/99441251/build.log
https://src.fedoraproject.org/rpms/datamash/blob/rawhide/f/datamash.spec

Perhaps you can change something in your build process such that make
install doesn't require makeinfo?


Best regards,
Georg

-- 
'The complexity for minimum component costs has increased at a
 rate of roughly a factor of two per year ... Certainly over the
 short term this rate can be expected to continue, if not to
 increase.' (Moore's law, 1965)