Re: [Bug-ddrescue] [PATCH 5/7] [clang-tidy] Don't use else after a return statement

[Rosen Penev]

On Tue, Oct 15, 2019 at 3:08 PM Paul Daniels <address@hidden> wrote:
>
>
> On 16/10/19 5:58 am, Antonio Diaz Diaz wrote:
> > Rosen Penev wrote:
> >> Found with readability-else-after-return
> >
> > I probably won't apply any of these. I'm somewhat annoyed by the "code
> > of conduct" that some compilers try to impose on developers. In
> > particular I find the folowing much more readable with the else than
> > without. Moreover, g++ could complain about "misleading indentation"
> > in the second case.
> >
> >> -      { if( domain < sb ) break; else continue; }
> >> +      { if( domain < sb ) break; continue; }
>
>
>      I concur.  The obsession over the code pedantry in the compiler
> seems to have simply gone just too far these days; readability is
> definitely going backwards which in turn makes for more potential bugs.
It really depends on the original codebase. I've seen this improve
readability in some and make it worse on others. On this one, it looks
worse.



>
>
> Regards,
>
> Paul.
>
>
> >
> > _______________________________________________
> > Bug-ddrescue mailing list
> > address@hidden
> > https://lists.gnu.org/mailman/listinfo/bug-ddrescue
>
> _______________________________________________
> Bug-ddrescue mailing list
> address@hidden
> https://lists.gnu.org/mailman/listinfo/bug-ddrescue